Skip to content

Add virtual beginMulticast(...) stub to UDP class #5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add virtual beginMulticast(...) stub to UDP class #5796

wants to merge 1 commit into from

Conversation

sandeepmistry
Copy link
Contributor

This allows libraries to use udp.beginMulti(..) when a UDP type is passed in. This method is optional and will fail by default if the network library does not support multicast UDP.

@PaulStoffregen
Copy link
Contributor

Do some protocols require also specifying a mac address?

This was referenced Jan 3, 2017
Merged
Merged
@sandeepmistry
Copy link
Contributor Author

@PaulStoffregen good question, so far I've only looked at mDNS. I'll do some more research at other protocols that use multicast UDP.

@sandeepmistry sandeepmistry changed the title Add virtual beginMulti(...) stub to UDP class Add virtual beginMulticast(...) stub to UDP class Jan 3, 2017
@sandeepmistry sandeepmistry mentioned this pull request Jan 3, 2017
Merged
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5796-BUILD-631-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5796-BUILD-631-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5796-BUILD-631-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5796-BUILD-631-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-5796-BUILD-631-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@sandeepmistry
Copy link
Contributor Author

sandeepmistry commented Jan 3, 2017 •
edited
Loading

The local IP would be handy.

I've been experimenting making the EthernetBonjour library compatible with WiFi101. For now, I've changed begin to pass in the local IP.

Progress can be found on the following fork + branch: https://github.com/sandeepmistry/EthernetBonjour/tree/generic-udp

@facchinm facchinm added Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) Architecture: SAM Applies only to the SAM microcontrollers (Due) labels Jan 20, 2017
@facchinm facchinm mentioned this pull request Jan 24, 2017
Merged
@facchinm
Copy link
Member

Partially moved to arduino/ArduinoCore-sam#6

@facchinm facchinm closed this Jan 24, 2017
@facchinm facchinm reopened this Jan 24, 2017
@mastrolinux mastrolinux added the in progress Work on this item is in progress label Jan 24, 2017
@facchinm facchinm added this to the Release 1.8.2 milestone Feb 8, 2017
@facchinm
Copy link
Member

facchinm commented Feb 8, 2017

Merged manually 26ae0ac

@facchinm facchinm closed this Feb 8, 2017
@mastrolinux mastrolinux removed the in progress Work on this item is in progress label Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Architecture: AVR Applies only to the AVR microcontrollers (Uno, etc.) Architecture: SAM Applies only to the SAM microcontrollers (Due)
Projects
None yet
Milestone
Release 1.8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@sandeepmistry @PaulStoffregen @ArduinoBot @facchinm @mastrolinux