Skip to content

Various improvements in build script #5778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2017
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 29, 2016

This PR contains the following fixes:

  • the IDE is now tolerant to missing package_index_bundled.json
  • the IDE is now tolerant to missing bundled libraries folder or missing sketchbook/librarires
  • the build script task arduino-builder-build has been factored out, so it's now more maintainable (one task for all architectures) and allow conditional build through env variable. This is based on @NicoHood's commit f29abf8

This should supersede and fix #5438

/cc @NicoHood

@NicoHood
Copy link
Contributor

NicoHood commented Jan 6, 2017

Those commits are missing:
5de6c1f
4cee989

@NicoHood
Copy link
Contributor

NicoHood commented Jan 7, 2017

The IDE also should be tolerant of a missing tools-builder folder:
https://bugs.archlinux.org/task/52377

Any chance to see a better fix?

@cmaglie
Copy link
Member Author

cmaglie commented Jan 8, 2017

Those commits are missing:
5de6c1f
4cee989

Those are already cherry-picked in master branch:

d3bd5f2
1da9108
8e6422f

@cmaglie
Copy link
Member Author

cmaglie commented Jan 8, 2017

The IDE also should be tolerant of a missing tools-builder folder:
https://bugs.archlinux.org/task/52377

Any chance to see a better fix?

How can I reproduce that?
Maybe you should open another issue, to better track this bug.

@NicoHood
Copy link
Contributor

NicoHood commented Jan 8, 2017

you need to delete the described folder (or better move it somewhere else) and change platform.txt to point to the new loation. make sure your .arduino15 folder does not exist, otherwise the bug is not triggered (as it is not for me)

@cmaglie
Copy link
Member Author

cmaglie commented Jan 25, 2017

It seems the builder that requires (at least) one -tools option, can you open an issue on the builder repository?

@cmaglie cmaglie merged commit 3d0a153 into arduino:master Jan 25, 2017
@cmaglie cmaglie deleted the fix-light-bundles branch January 25, 2017 15:24
@cmaglie cmaglie added this to the Release 1.8.2 milestone Jan 25, 2017
@cmaglie cmaglie added the Component: IDE The Arduino IDE label Jan 25, 2017
@NicoHood
Copy link
Contributor

Fixes seem to be applied properly. Thanks a lot!

The only thing left for packaging arduino securely now are the gpg signatures:
#5772 (comment)

You can use my gpgit script which is straight forward and super easy with github:
https://github.com/NicoHood/gpgit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants