Skip to content

allow 3rd party boards that depend on sam core to use their own USB vid/pid and manufacturer/product strings #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 15, 2016

Conversation

philmanofsky
Copy link
Contributor

My company is creating a product (open source MIDI controller) that uses the same chip as the Arduino Due (SAM3X series). I created a new board package with a "boards.txt" file which uses the Due's core files. The changes that I propose in this Pull Request allow boards like my company's board (which depend on the sam core) to define their own USB vendor/product ID's and manufacturer/product strings in "boards.txt" that show up when enumerating the USB device.

Please consider committing this request. Otherwise, my company's product will show up as "Arduino Due" in Digitial Audio Workstations like Ableton after people edit/upload the firmware.

Phil Manofsky added 4 commits March 14, 2016 23:09
allows people to create board that depends on sam core to use their own Vendor ID instead of Arduino's
now "myboard.build.usb_product" and "myboard.build.usb_manufacturer" from a 3rd party board in "boards.txt" are used in source code. if they aren't defined in "boards.txt", default values are used.
3rd party boards that use sam core can have their own USB product ID that is defined in "boards.txt"
added "build.usb_manufacturer" entry that overrides default macro in USBCore.cpp source file. this isn't really necessary since the source macro is the same as in "boards.txt", but it gives 3rd party board vendors direction in how to have their SAM3X board use their own manufacturer string during USB enumeration.
sandeepmistry added a commit to sandeepmistry/Arduino that referenced this pull request Mar 15, 2016
allow 3rd party boards that depend on sam core to use their own USB vid/pid and manufacturer/product strings
@sandeepmistry sandeepmistry merged commit 1983f7a into arduino:master Mar 15, 2016
@sandeepmistry
Copy link
Contributor

@philmanofsky thanks!

@philmanofsky
Copy link
Contributor Author

@sandeepmistry you are welcome and thank you! Question. When will this code be integrated as part of the "Arduino ARM" package that you install from boards manager? Should I have also changed the platform.txt version to 1.6.8? Again, thank you for the merge. That was super quick and is going to help my company (and other 3rd party vendors) a lot :)

@philmanofsky
Copy link
Contributor Author

@sandeepmistry also, is there an hourly build of the SAM core? i saw an hourly build for the SAMD core, so i figured i would ask...

@sandeepmistry
Copy link
Contributor

When will this code be integrated as part of the "Arduino ARM" package that you install from boards manager?

It will be available in the next release, however we do not have any timelines on this.

is there an hourly build of the SAM core?

Unfortunately no. There are a few issues preventing us from splitting the SAM core into a new repo like the SAMD core, this is blocking having hourly builds.

@philmanofsky
Copy link
Contributor Author

@sandeepmistry if i want to speed up the process of a new sam core release, do I need to change "version=1.6.7" in the platform.txt file to "version=1.6.8"?

@cmaglie cmaglie modified the milestones: Release 1.6.9, Release 1.6.8 Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants