Skip to content

Save windows position when closed with Alt+F4 or "X" button #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2016

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 15, 2016

@cmaglie cmaglie added feature request A request to make an enhancement (not a bug fix) Component: IDE user interface The Arduino IDE's user interface labels Jan 15, 2016
@cmaglie cmaglie self-assigned this Jan 15, 2016
@cmaglie cmaglie added this to the Release 1.6.8 milestone Jan 15, 2016
@matthijskooijman
Copy link
Collaborator

Commits look good to me.

@PickyBiker
Copy link

This works well for me. It saves a lot of time repetitively resizing and locating windows. Thank you for implementing it.

@PickyBiker
Copy link

I just noticed that if I start by clicking on Arduino.exe it works well. I associated .ino files with Arduino.exe. If I then start it by clicking on an .ino file, it starts arduino.exe but it doesn't remember the last window position.

The check for "resolution-changed" is performed when an editor
location is retrieved from preferences. This commit rationalize
access to PreferencesData and prepares for the next improvement.
This allows the use-case with users editing one sketch at a time, that
seems to be the most common scenario:

 1. User position the editor as desired
 2. User close the IDE
 3. User opens the IDE by double clicking on another .ino file
 4. The IDE is opened again at the same position

See arduino#4432
@PickyBiker
Copy link

The windows version gets an error when it runs:

@PickyBiker
Copy link

Here is the error
error

@cmaglie
Copy link
Member Author

cmaglie commented Jan 25, 2016

Hi @PickyBiker,
I've just checked the build and it starts without problems, may you check the downloaded file (it should be154848694 bytes long) and the unzipped folder to see if it contains a "java" subfolder?

@PickyBiker
Copy link

Okay, I re-downloaded the file and it worked this time.

Now it remember the window position whether I start it with Arduino or the .ino file.

Nice job, thank you very much. I'm sure others will like this as well.

As a further thank you, I am going to donate $50 when I download the released 1.68 version.

Once again, thank you!

@cmaglie cmaglie merged commit 0bceb93 into arduino:master Jan 25, 2016
@cmaglie cmaglie deleted the save-on-close branch January 25, 2016 16:57
@willie68
Copy link

willie68 commented May 5, 2016

Great, working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember window positions
5 participants