Skip to content

SystemProfilerParse fix for OSX El Capitan #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2015
Merged

SystemProfilerParse fix for OSX El Capitan #4006

merged 2 commits into from
Oct 21, 2015

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 20, 2015

This PR contains:

  • a small refactoring of SystemProfilerParser class
  • a fix for serial port detection for OSX El Capitan

should alleviate #3928.
/cc @facchinm

@cmaglie
Make SystemProfilerParser.extractVIDAndPID() static
28ad89d 
There is no need to instantiate a SystemProfilerParser object
each time extractVIDAndPID is invoked.

Added also `synchronized` keword to avoid reentrance problems
if the method is being used in multiple threads.
@cmaglie
Fixed parsing for SystemProfiler on Macosx El Capitan
2ae3694 
Should alleviate arduino#3928
@cmaglie cmaglie added Component: IDE The Arduino IDE Type: Bug OS: OSX Specific to the Mac OS X (macOS) version of the Arduino IDE labels Oct 20, 2015
@ArduinoBot
Copy link
Contributor

Build successful. Please test this code using one of the following:
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4006-BUILD-417-linux32.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4006-BUILD-417-linux64.tar.xz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4006-BUILD-417-windows.zip
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4006-BUILD-417-macosx.zip

facchinm added a commit that referenced this pull request Oct 21, 2015
@facchinm
Merge pull request #4006 from cmaglie/sys_prof_parse_fix
a396f2a 
SystemProfilerParse fix for OSX El Capitan
@facchinm facchinm merged commit a396f2a into arduino:master Oct 21, 2015
@cmaglie cmaglie deleted the sys_prof_parse_fix branch October 21, 2015 08:34
@ffissore ffissore modified the milestone: Release 1.6.6 Oct 26, 2015
@ffissore ffissore mentioned this pull request Oct 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: IDE The Arduino IDE OS: OSX Specific to the Mac OS X (macOS) version of the Arduino IDE Type: Bug
Projects
None yet
Milestone
Release 1.6.6
Development

Successfully merging this pull request may close these issues.
4 participants
@cmaglie @ArduinoBot @ffissore @facchinm