Recusively copying additional files #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffissore
added
Component: IDE
…pied to build folder. Fixes #3080
ffissore
added a commit
that referenced
this pull request
Jun 30, 2015
Recusively copying additional files
ffissore
pushed a commit
that referenced
this pull request
Jun 30, 2015
… be copied to build path. Hence, restored previous "copy sketch file" logic, couples with a recursive one, used only for files external to the sketch (in subfolders)
|
Hm, something I realized about this change: Before, you could modify and compile a sketch without having to save your changes, I believe. With this change, this only applies to .ino files, but any unsaved changes to other files will be ignored I think? Wouldn't it be more consistent anyway to add any files in subdirs to the sketch's file list (and have them opened in the IDE) instead of modifying just the compile process? |
|
Right, I took the wrong way when fixing this and it popped up with #3440. I've reverted to the previous code in 9a01e30 and isolated the copy of files only to those in subfolders, so now it works again as it used to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler: additional files with allowed extentions are recursively copied to build folder. Fixes #3080