Add missing case to detachinterrupt #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2015
ffissore
added
Component: Core
|
Thank you! |
|
Note that this now produces a warning if one compiles any sketch with a board that does not support INT2, like the Uno: /Users/Lauszus/Github/Arduino/build/macosx/work/Arduino.app/Contents/Java/hardware/arduino/avr/cores/arduino/WInterrupts.c: In function 'detachInterrupt':
/Users/Lauszus/Github/Arduino/build/macosx/work/Arduino.app/Contents/Java/hardware/arduino/avr/cores/arduino/WInterrupts.c:235:8: warning: #warning detachInterrupt may need some more work for this cpu (case 2) [-Wcpp]
#warning detachInterrupt may need some more work for this cpu (case 2)
^It is properly a good idea to check if INT2 is actually defined before issuing the warning? |
|
Please see my PR: #3244. |
klightspeed
pushed a commit
to klightspeed/EthertenMP3Player
that referenced
this pull request
Aug 30, 2015
…errupt This was caused after: arduino/Arduino#3221
klightspeed
pushed a commit
to klightspeed/Arduino-Libraries
that referenced
this pull request
Sep 6, 2015
…errupt This was caused after: arduino/Arduino#3221 (Filtered from arduino/Arduino@272d5cc)
neu-rah
pushed a commit
to neu-rah/VirtualPins
that referenced
this pull request
Apr 10, 2017
…errupt This was caused after: arduino/Arduino#3221
facchinm
pushed a commit
to arduino/ArduinoCore-avr
that referenced
this pull request
Sep 20, 2017
…errupt This was caused after: arduino/Arduino#3221
facchinm
pushed a commit
to arduino/ArduinoCore-avr
that referenced
this pull request
Sep 20, 2017
…errupt This was caused after: arduino/Arduino#3221
facchinm
pushed a commit
to arduino/ArduinoCore-avr
that referenced
this pull request
Sep 20, 2017
…errupt This was caused after: arduino/Arduino#3221
facchinm
pushed a commit
to arduino/ArduinoCore-avr
that referenced
this pull request
Sep 20, 2017
…errupt This was caused after: arduino/Arduino#3221
facchinm
pushed a commit
to arduino/ArduinoCore-avr
that referenced
this pull request
Sep 20, 2017
…errupt This was caused after: arduino/Arduino#3221
rickyrockrat
pushed a commit
to rickyrockrat/Arduino.hardware
that referenced
this pull request
Apr 10, 2018
…errupt This was caused after: arduino/Arduino#3221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1191 and issue #879. Adds missing case to detachInterrupt for INT2.