Skip to content

[IDE 1.5.x] Command-line / GUI refactor. #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 73 commits into from
Nov 18, 2014
Merged

[IDE 1.5.x] Command-line / GUI refactor. #2328

merged 73 commits into from
Nov 18, 2014

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 26, 2014

This is a proposal for the rationalization of the Arduino IDE code.
More info coming.

@cmaglie cmaglie force-pushed the ide-1.5.x-gui-refactor branch from 2339395 to 89a442b Compare October 13, 2014 14:59
@championswimmer
Copy link
Contributor

what is the current status on this ?
by when do we expect this to be merged ?

@cmaglie cmaglie force-pushed the ide-1.5.x-gui-refactor branch from 89a442b to 79e3db1 Compare October 28, 2014 17:58
@cmaglie
Copy link
Member Author

cmaglie commented Oct 28, 2014

Just pushed a fix and rebased on current master, let's see if the bot is able to create the build.

@ArduinoBot
Copy link
Contributor

Build failed.

@ffissore
Copy link
Contributor

Build failed with batchtest doesn't support the "skipNonTests" attribute. If you wish to temporarily disable a test, append @Ignore annotation right below @Test

@ffissore ffissore closed this Oct 29, 2014
@ffissore ffissore reopened this Oct 29, 2014
@cmaglie cmaglie force-pushed the ide-1.5.x-gui-refactor branch 2 times, most recently from fc88ce5 to b0b40da Compare November 2, 2014 12:12
@ArduinoBot
Copy link
Contributor

Build successful. Please test this code using one of the following:
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-2328-BUILD-80-linux32.tgz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-2328-BUILD-80-linux64.tgz
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-2328-BUILD-80-windows.zip
http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-2328-BUILD-80-macosx.zip

@agdl
Copy link
Member

agdl commented Nov 3, 2014

Tested:

  • Upload on UNO, Leonardo, MEGA 2560, DUE, Esplora, Micro, Ehernet;
  • Serial monitor opening;
  • Modify preferences;
  • Copy for forum (even with mods to read only files):
  • Copy HTML (even with mods to read only files);
  • Autoformat;
  • All the links in help menu;
  • Import library;
  • Add file;
  • Show sketch folder;
  • Save & open;
  • Find & Replace. Use selection for find;
  • Uploading of a sketch with many files;

Everything works without strange behaviour

matthijskooijman and others added 18 commits November 13, 2014 16:18
@matthijskooijman @cmaglie
Explicitely store a layout type for a library
a601372 
Previously, the useRecursion and srcFolders were filled on library
creation, based on the existence of the src folder. Now, a layout
variable is set, and the useRecursion() and getSrcFolder() methods
change their return value based on the layout in use.
@matthijskooijman @cmaglie
Let Sketch.getExtensions() return a List
af0d8c7 
This simplifies upcoming changes.
@matthijskooijman @cmaglie
Use SketchCode.isExtension in more places
43dac3a
@matthijskooijman @cmaglie
Don't store the extension in SketchCode
e994c52 
Nobody was using it anymore, except for checking against specific
extensions, which is easily done against the filename itself. This
prepares for some simplification of Sketch.load next.
@cmaglie
Removed unused Base.getBoardsViaNetwork() and related member.
9bc1824
@cmaglie
Removed some trivial warnings
dd911bc
@cmaglie
Removed some warning from Editor class
026dd50
@cmaglie
Refactoring of Theme class
479b974
@cmaglie
Refactored and simplified EditorConsole class.
93562a7
@cmaglie
Splitted GUI and Streams in EditorConsole
872897d
@cmaglie
Rationalized Preferences and Theme classes.
af19257 
Removed a lot of duplicate/unused code. Preferences un-marshalling
is now handled in PreferencesMap class.
@bitron @cmaglie
Removed GUI dependencies from SketchCode class.
e6563cf 
Moved GUI fields into a SketchCodeDocument container class.
@bitron @cmaglie
Make Compiler independent from Sketch.
79ab98f 
Create a class SketchData to store all relevant data for a sketch
(trying to keep GUI stuff out of the way).

Moved preprocessing code from Sketch to Compiler.
@cmaglie
Reintroduced 'Next Tab' and 'Prev Tab' click actions
bbd3782
@cmaglie
Applied (a sort of) decorator pattern to SketchCodeDoc.
54f3f53 
SketchCodeDoc renamed to SketchCodeDocument.
Compiler is now independent from SketchCodeDocument.
@bitron @cmaglie
Made Compiler and PdePreprocessor independent from Preferences.
b61f2a4 
Created a class PreferencesData to manage all parameters except the ones for the GUI.
Removed GUI parameters management from ParametersMap.
Created ParametersHelper class to help with GUI parameters management.
Used ParametersHelper in Themes.
@bitron @cmaglie
Moved some code from Sketch to SketchData.
21de7bd
@cmaglie
Created PApplet and PConstants wrapper classes.
18a8d4d 
Also removed unused ColorSelector and CreateFont to reduce wrappers
size to the minimum.
This commit is preparatory for dropping dependency on processing-core.
bitron and others added 18 commits November 13, 2014 16:23
@bitron @cmaglie
Moved onBoardOrPortChange() and related members/methods from Base to …
abe6ff5 
…BaseNoGui.
@bitron @cmaglie
Moved some parameter processing methods from Base to BaseNoGui.
443f7a7
@bitron @cmaglie
Moved some code from Base to BaseNoGui into new getSketchbookPath() m…
10af59f 
…ethod.
@bitron @cmaglie
Moved portableSketchbookFolder from Base to BaseNoGui.
2058263
@bitron @cmaglie
Refactored Base.getDefaultSketchbookFolder() method.
26a8b37
@bitron @cmaglie
Moved getDefaultSketchbookFolder() from Base to BaseNoGui and other m…
035e57e 
…inor fixes.
@bitron @cmaglie
Moved commandline parsing code from Base/BaseNoGui to new Commandline…
6d28e12 
…Parser class.
@bitron @cmaglie
Moved getBuildFolder() and related members/methods from Base to BaseN…
4d3599b 
…oGui.
@bitron @cmaglie
Added main() and init() methods to BaseNoGui.
2702cce 
Now the the GUI and the rest of the code should be completely separated.
@bitron @cmaglie
Fixed wrong sketch structure check.
c222310
@bitron @cmaglie
Removed inheritance relationship between SketchCodeDocument and Sketc…
b2a88ec 
…hCode.
@bitron @cmaglie
Added new command line options.
1974d77 
--buildpath
--nouploadport
--useprogrammer
@bitron @cmaglie
Modified preferences initialization in BaseNoGui.
2de206c
@cmaglie
Split IDE into 2 projects.
ba8eade 
BEWARE: HIGHLY EXPERIMENTAL BRANCH
@cmaglie
arduino-core project is now correctly compiled through ant build script
d1f4e03
@bitron @cmaglie
Moved specialized Platform classes and related resources to the 'ardu…
98bdc7b 
…ino-core' project.
@bitron @cmaglie
Created 'arduino-builder' project.
820fc65
@cmaglie
Temporarily disabled I18N test
7b2ed12
@cmaglie cmaglie force-pushed the ide-1.5.x-gui-refactor branch from b0b40da to 7b2ed12 Compare November 13, 2014 15:34
@cmaglie cmaglie self-assigned this Nov 18, 2014
@cmaglie cmaglie added Component: IDE The Arduino IDE Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix) Version: 1.5.x labels Nov 18, 2014
@cmaglie cmaglie added this to the IDE 1.5 stable milestone Nov 18, 2014
@cmaglie cmaglie merged commit 7b2ed12 into ide-1.5.x Nov 18, 2014
@cmaglie cmaglie deleted the ide-1.5.x-gui-refactor branch November 18, 2014 18:08
cmaglie added a commit to cmaglie/Arduino that referenced this pull request Nov 7, 2016
@cmaglie
Removed old prototype code from arduino#2328 that is now in Base
ae80711
@cmaglie cmaglie mentioned this pull request Nov 7, 2016
Merged
cmaglie added a commit to cmaglie/Arduino that referenced this pull request Nov 25, 2016
@cmaglie
Removed old prototype code from arduino#2328 that is now in Base
8eae641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmaglie cmaglie

Labels
Component: IDE user interface The Arduino IDE's user interface Component: IDE The Arduino IDE feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Milestone
IDE 1.5 stable
Development

Successfully merging this pull request may close these issues.
7 participants
@cmaglie @championswimmer @ArduinoBot @ffissore @agdl @matthijskooijman @bitron