Fix for issue 392

[ricklon]

I've had the patches available in issue 392 for quite a while. Included in this pull request is the fix, and the test for the fix. Please let me know if there are any issue.

[damellis]

There are still lots of unrelated changes in this pull request. Do you want to submit a patch that just fixes the !!! bug? Otherwise, we should probably just use the most recent version of the stk500v2 bootloader, with all the changes you've made. Where's that?

[ricklon]

David,

I've arranged this patch for Mark. I thought it was pretty minimal. I
did check it and it fixed the issues, but the details are Mark's so I
don't know the answer.

--Rick

On Sun, Jun 12, 2011 at 6:16 AM, damellis
[email protected]
wrote:

There are still lots of unrelated changes in this pull request.  Do you want to submit a patch that just fixes the !!! bug?  Otherwise, we should probably just use the most recent version of the stk500v2 bootloader, with all the changes you've made.  Where's that?

Reply to this email directly or view it on GitHub:
#23 (comment)

President
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

[damellis]

There's lots of stuff here that's (apparently) not needed to fix the problems caused by a !!! in an uploaded hex file. It's probably all good stuff, though! But as long as we're fixing more than just that one bug, it seems like we might as well just update to Mark's latest (stable) version of the code (which, as I recall, included even more fixes and improvements). Do you know which that is?

[ricklon]

David,

Would it make sense to split this out as a separate project in Github?
It could be worked on separately, and then packaged back in for
releases.

--Rick

On Sun, Jun 12, 2011 at 6:52 PM, damellis
[email protected]
wrote:

There's lots of stuff here that's (apparently) not needed to fix the problems caused by a !!! in an uploaded hex file.  It's probably all good stuff, though!  But as long as we're fixing more than just that one bug, it seems like we might as well just update to Mark's latest (stable) version of the code (which, as I recall, included even more fixes and improvements).  Do you know which that is?

Reply to this email directly or view it on GitHub:
#23 (comment)

President
Fair Use Building and Research (FUBAR) Labs
http://fubarlabs.org

[damellis]

It looks like you've got two versions of the stk500v2 bootloader, one in your 392 branch (the one in this pull request) and one in your issue392 branch (which contains additional changes). Let me explain a bit more about my thoughts that might help us figure out how to proceed. If we apply a very simple patch (e.g. the three lines with rcvdCharCntr), then I'd feel okay shipping it with only minimal testing. Anything more than that, though, like either the 392 or the issue392 changes, and we should probably do a full "release test", with comprehensive trials in a variety of situations. So, if we're going to do that, we might as well include all of the changes that Mark has made. If we want to avoid it, we should really make the changes as small as possible (i.e. only a few lines).

In any case, I'm happy to have you guys maintain your version of the bootloader wherever is most convenient for you. Placing it in a branch of a fork of the Arduino repository (as now) makes it easy for me to merge in via a pull request, but that's not essential if another arrangement works better for you.

In any case, let me know what you think about which of the two approaches we should take.

[msproul]

this is going to be replaced by a new pull request