Skip to content

typo in Adafruit_ST7735 #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

maqifrnswa
Copy link
Contributor

examples fail to build because it can't find Adafruit_GFX.h

this pull fixes that

@ffissore
Copy link
Contributor

ffissore commented Oct 9, 2013

Which version of the IDE are you using? All the examples are compiling fine

@maqifrnswa
Copy link
Contributor Author

Arduino version 1.0.5
avr-g++ (GCC) 4.7.2
avr-libc 1.8.0

/usr/share/arduino/hardware/tools/avr/bin/avr-g++ -c -g -Os -Wall -fno-exceptions -ffunction-sections -fdata-sections -mmcu=atmega328p -DF_CPU=16000000L -MMD -DUSB_VID=null -DUSB_PID=null -DARDUINO=105 -D__PROG_TYPES_COMPAT__ -I/usr/share/arduino/hardware/arduino/cores/arduino -I/usr/share/arduino/hardware/arduino/variants/standard -I/usr/share/arduino/libraries/SPI -I/usr/share/arduino/libraries/SD -I/usr/share/arduino/libraries/TFT /tmp/build1538439083639920124.tmp/TFTBitmapLogo.cpp -o /tmp/build1538439083639920124.tmp/TFTBitmapLogo.cpp.o
In file included from /usr/share/arduino/libraries/TFT/TFT.h:7:0,
from TFTBitmapLogo.ino:25:
/usr/share/arduino/libraries/TFT/utility/Adafruit_ST7735.h:28:26: fatal error: Adafruit_GFX.h: No such file or directory
compilation terminated.

@ffissore
Copy link
Contributor

uhm gcc 4.7.2 and avrlibc 1.8, these versions are not supported. Have you installed arduino from a package repository for your linux distro? Which distro is it?

@maqifrnswa
Copy link
Contributor Author

I maintain the Debian package and try to report upcoming problems arduino
will face along with solutions (for example
#1448). This bug is not present in
the default download, but it is present in the default download if I use a
newer gcc.

Many are bugs in the libraries that don't show up in the current package
because the compiler isn't strict (yet). This is a problem that arduino
will have to deal with at some point as it moves to newer compilers and
newer hardware.

The severity of this is minor, or a "wishlist" item that would escalate
whenever arduino adopts a newer (or stricter) compiler. However, enough
users are using these libraries that if there is a typo (see below), it
should be fixed sooner than later.

More info:
TFT.h currently #includes "utility/Adafruit_GFX.h" and
"utility/Adafruit_ST7735.h" (that is correct) but utility/Adafruit_ST7735.h
#includes <Adafruit_GFX.h> (if not defined, so the question is why is every
other header file using "" but Adafruit_ST7735.h using <>, especially if it
places it outside of the search path for includes)

Maybe you can explain why it is in <> and I can patch it accordingly.
Thanks.

@maqifrnswa
Copy link
Contributor Author

@maqifrnswa maqifrnswa closed this Oct 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants