Only disable timer interrupt instead of all interrutps in millis()/micros() #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In wiring lib, usualy a global interrupt disabled is issued when not realy needed. It's very bad for timed interrupt sensitive designs More info at: http://forum.arduino.cc/index.php?topic=168864.0
|
It also saves 2 bytes of program code with this fix. |
This was referenced May 28, 2013
cmaglie
added
feature request
matthijskooijman
changed the title
|
Looking through old PR's, I think this one is actually worth merging. It does need to be rebased and needs a better commit message, though. |
|
If someone wants to adopt this PR, please open a new one using this link https://github.com/arduino/ArduinoCore-avr/compare/pr_1442?expand=1 , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wiring lib, usualy a global interrupt disabled is issued when not realy needed.
It's very bad for timed interrupt sensitive designs
More info at: http://forum.arduino.cc/index.php?topic=168586.0