Skip to content

Recursive library compilation #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Recursive library compilation #1152

wants to merge 4 commits into from

Conversation

ffissore
Copy link
Contributor

@ffissore ffissore commented Dec 4, 2012

This patch will trigger recursive compilation only for the "fat" (multi platform) libraries.

The old logic remains unchanged.

This replaces #116 that triggered recursive compilation for every library, possibly incurring in compilation errors: it would have compiled things like documentation and examples (that, it turns out, usually don't compile) thus breaking things that used to work fine.

@lestofante
Copy link

please take a look at #116.
Test show no compilation fault in all code tested.

2012/12/4 Federico Fissore [email protected]

This patch will trigger recursive compilation only for the "fat" (multi
platform) libraries.

The old logic remains unchanged.

This replaces #116 #116 that
triggered recursive compilation for every library, possibly incurring in
compilation errors: it would have compiled things like documentation and
examples (that, it turns out, usually don't compile) thus breaking things

that used to work fine.

You can merge this Pull Request by running:

git pull https://github.com/ffissore/Arduino ide-1.5.x

Or view, comment on, or merge it at:

#1152
Commit Summary

  • removed check on .h file existence
  • recursive library compilation triggered on multiplatform libraries

File Changes

  • M app/src/processing/app/Base.java (5)
  • M app/src/processing/app/debug/Compiler.java (56)

Patch Links

@ffissore
Copy link
Contributor Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants