-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Two protected areas in Stream.h #6146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is intentional. Apparently it used to be Tip: use the Blame button when browsing a file on Github (https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/cores/arduino/Stream.h) to see which was the last commit to affect each line of the file. |
So the only change needed is to fix the comments. @cmaglie, perhaps you could fix this? Or make me collaborator on the sam/samd repositories too so I can push a simple fix? |
…rotected These functions were changed from private to protected in arduino@99f2a27 but the comments were not updated at that time. In conjunction with equivalent pull requests to Arduino SAM Boards and Arduino SAMD Boards, solves arduino#6146.
…rotected These functions were changed from private to protected in arduino/Arduino@99f2a27 but the comments were not updated at that time. In conjunction with equivalent pull requests to Arduino SAM Boards and Arduino SAMD Boards, solves arduino/Arduino#6146.
…rotected These functions were changed from private to protected in arduino/Arduino@99f2a27 but the comments were not updated at that time. In conjunction with equivalent pull requests to Arduino SAM Boards and Arduino SAMD Boards, solves arduino/Arduino#6146.
…rotected These functions were changed from private to protected in arduino/Arduino@99f2a27 but the comments were not updated at that time. In conjunction with equivalent pull requests to Arduino SAM Boards and Arduino SAMD Boards, solves arduino/Arduino#6146.
…rotected These functions were changed from private to protected in arduino/Arduino@99f2a27 but the comments were not updated at that time. In conjunction with equivalent pull requests to Arduino SAM Boards and Arduino SAMD Boards, solves arduino/Arduino#6146.
…rotected These functions were changed from private to protected in arduino/Arduino@99f2a27 but the comments were not updated at that time. In conjunction with equivalent pull requests to Arduino SAM Boards and Arduino SAMD Boards, solves arduino/Arduino#6146.
…rotected These functions were changed from private to protected in arduino/Arduino@99f2a27 but the comments were not updated at that time. In conjunction with equivalent pull requests to Arduino SAM Boards and Arduino SAMD Boards, solves arduino/Arduino#6146.
…rotected These functions were changed from private to protected but the comments were not updated at that time. In conjunction with equivalent pull requests to Arduino AVR Boards and Arduino SAMD Boards, solves arduino#6146.
Is it a typo? The first one should be private according to the comments.
protected:
protected:
The text was updated successfully, but these errors were encountered: