Skip to content

Line continuation character ignored by syntax highlighting #5888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
septillion-git opened this issue Jan 20, 2017 · 6 comments
Closed

Line continuation character ignored by syntax highlighting #5888

septillion-git opened this issue Jan 20, 2017 · 6 comments
Assignees
Milestone

Comments

@septillion-git
Copy link

septillion-git commented Jan 20, 2017

The line continuation character \ is not parsed by the syntax highlighting if it's part of a line comment.

// I start a comment on this line but I end with the line continuation character \
byte test = 5; //This WHOLE line is a comment because of the line continuation character on the last line

//The byte test is thereby NOT declared but the syntax highlighting of the IDE does not display it as comment

This way it's easy for a newbie to do this without knowing what's wrong. If the line was highlighted as comment the error would have been more clear.

Link to a case where it happened:
http://forum.arduino.cc/index.php?topic=449738.0

@facchinm
Copy link
Member

The feature you are requesting should be implemented by RSyntaxTextArea, the Java library we use as text editor.
Reopening the issue there will surely boost the visibility of this issue. Thanks for reporting!

@septillion-git
Copy link
Author

Thanks for pointing me to RSTA! You talk about a closed (but unfixed) issue over at RSTA, I can't find it, do you have by any change the issue number?

@facchinm
Copy link
Member

Sorry @septillion-git , I meant "file a new issue there about the same topic" 😄 Thanks!

@septillion-git
Copy link
Author

Thanks! I will :)

Quick other question, is it by design that c-style strings are not highlighted anymore? On 1.6.4 they turn blue, on 1.8.1 nothing happens to them. Or is that a RSTA bug as well?

@septillion-git
Copy link
Author

RSTA fixed the bug :) Hopefully it's implemented in the IDE quick .

Still remain the question about strings...

@facchinm
Copy link
Member

As soon as 2.6.1 gets released we'll import it in the IDE! Thanks for pushing this!

facchinm added a commit to facchinm/Arduino that referenced this issue Feb 7, 2017
@ghost ghost assigned facchinm Feb 7, 2017
@ghost ghost added the in progress Work on this item is in progress label Feb 7, 2017
matthijskooijman added a commit to matthijskooijman/Arduino that referenced this issue Feb 14, 2017
This imports the unmodified upstream version of RSTA from
http://repo1.maven.org/maven2/com/fifesoft/rsyntaxtextarea/2.6.1/rsyntaxtextarea-2.6.1.jar
since the Arduino-specific changes are no longer required.

This fixes arduino#5888
cmaglie pushed a commit to cmaglie/Arduino that referenced this issue Feb 24, 2017
This imports the unmodified upstream version of RSTA from
http://repo1.maven.org/maven2/com/fifesoft/rsyntaxtextarea/2.6.1/rsyntaxtextarea-2.6.1.jar
since the Arduino-specific changes are no longer required.

This fixes arduino#5888
cmaglie pushed a commit to cmaglie/Arduino that referenced this issue Feb 27, 2017
This imports the unmodified upstream version of RSTA from
http://repo1.maven.org/maven2/com/fifesoft/rsyntaxtextarea/2.6.1/rsyntaxtextarea-2.6.1.jar
since the Arduino-specific changes are no longer required.

This fixes arduino#5888
cmaglie pushed a commit to cmaglie/Arduino that referenced this issue Mar 1, 2017
This imports the unmodified upstream version of RSTA from
http://repo1.maven.org/maven2/com/fifesoft/rsyntaxtextarea/2.6.1/rsyntaxtextarea-2.6.1.jar
since the Arduino-specific changes are no longer required.

This fixes arduino#5888
@cmaglie cmaglie closed this as completed in f5eb673 Mar 1, 2017
@ghost ghost removed the in progress Work on this item is in progress label Mar 1, 2017
@cmaglie cmaglie added this to the Release 1.8.2 milestone Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants