Skip to content

I18N for compilation message - IDE1.8.0 #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Myriads opened this issue Dec 24, 2016 · 4 comments
Closed

I18N for compilation message - IDE1.8.0 #5757

Myriads opened this issue Dec 24, 2016 · 4 comments
Milestone

Comments

@Myriads
Copy link

Myriads commented Dec 24, 2016

The previous version IDE provides the L10N for compilation message but IDE1.8.0 doesn't:

Sketch uses 2660 bytes (8%) of program storage space. Maximum is 32256 bytes.
Global variables use 208 bytes (10%) of dynamic memory, leaving 1840 bytes for local variables. Maximum is 2048 bytes.

@facchinm
Copy link
Member

facchinm commented Jan 2, 2017

Hi @Myriads, that shouldn't happen since we preserved the wording when moving the sketch size calculation from the IDE to arduino-builder.
If I set the IDE language in Korean I get

스케치는 프로그램 저장 공간 9056 바이트(3%)를 사용. 최대 262144 바이트.

Is it correct? How can I replicate your configuration?

@facchinm facchinm added the Waiting for feedback More information must be provided before we can proceed label Jan 2, 2017
@facchinm facchinm changed the title L10N for compilation message - IDE1.8.0 I18N for compilation message - IDE1.8.0 Jan 2, 2017
@Myriads
Copy link
Author

Myriads commented Jan 3, 2017

Hi @facchinm. The message you got is correct. If you run the update.sh script at the i18n and rebuild, then messages always are displayed in English. But old Resources_ko_KR.p* files are used, then messages are correctly displayed.

@Myriads
Copy link
Author

Myriads commented Jan 3, 2017

I replicated this. Please build resource files with update.sh and rebuild IDE, then messages are displayed in English. And also I can not find out the msgids in Resources_ko_KR.po file.

image

@facchinm
Copy link
Member

facchinm commented Jan 3, 2017

You are totally right; indeed 1a97ec4 removed the Java strings but the actual resources in 1.8.0 are correct (still don't know why). Anyway, I'm pushing the strings back and recreating the resources. Thanks for helping!

facchinm added a commit to facchinm/Arduino that referenced this issue Jan 3, 2017
cmaglie pushed a commit that referenced this issue Jan 4, 2017
@cmaglie cmaglie added this to the Release 1.8.1 milestone Jan 4, 2017
@cmaglie cmaglie removed the Waiting for feedback More information must be provided before we can proceed label Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants