Skip to content

Add INPUT_PULLDOWN to keywords.txt #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarkusLange opened this issue Jul 15, 2015 · 7 comments
Closed

Add INPUT_PULLDOWN to keywords.txt #3534

MarkusLange opened this issue Jul 15, 2015 · 7 comments
Labels
Component: IDE The Arduino IDE

Comments

@MarkusLange
Copy link

INPUT_PULLDOWN LITERAL2 Constants RESERVED_WORD_2

is missing INPUT_PULLDOWN has no color

Chris--A added a commit to Chris--A/Arduino that referenced this issue Jul 16, 2015
@facchinm
Copy link
Member

Hi @MarkusLange , indeed INPUT_PULLDOWN is not a valid keyword as it's not declared anywhere in the IDE 😄
Where did you find it?

@Chris--A
Copy link
Contributor

A custom library maybe?

A quick search shows it might be part of a custom core for something like an MSP432
http://forum.43oh.com/topic/8295-pinmode-input-pulldown-not-working-properly-on-msp432/
https://community.particle.io/t/difference-between-input-input-pullup-input-pulldown/8543

@facchinm
Copy link
Member

I also thought it was in a custom library, but if the code is declared inside a custom core you can't specify a custom keyboard.txt (issue #755). Leaving open for reference

@facchinm facchinm added the Component: IDE The Arduino IDE label Jul 16, 2015
@MarkusLange
Copy link
Author

Hi Chris, hi facchinm,

I found in ...\samd\cores\arduino\wiring_digital.c from the new ZERO Board, the ZERO has pull-up and pull-down resistors on the pins.

@facchinm
Copy link
Member

Well, this is a bit awkward 😁 I didn't grep inside Zero core actually.
We can't add the keyword platform-wide (if we don't provide an alias of INPUT as INPUT_PULLDOWN of course) but I'll push to solve #755 and then we'll add the keyword only to Zero core.
Thank you very much Markus!

@MarkusLange
Copy link
Author

Not for that. I tripped over it because of a similar issue (https://forum.pjrc.com/threads/29140-Bug-in-teensy-installer-for-arduino-1-6-5-r2) and my messing around on the Onewire lib to get the Zero on duty, works so far, (http://forum.arduino.cc/index.php?topic=331220.msg2297555#msg2297555) but I don't get the basic operations, direct register access working.

@PaulStoffregen
Copy link
Contributor

I have long wanted this #755 feature for Teensy. Of course, not enough to dig into the IDE source to implement it....

Until recently, there's been relatively little activity in the global keywords.txt file, so I've just installed a patched copy. Obviously that's not so good.

Ideally, the keywords.txt from core libraries could apply in addition to the global one, much like how the keyboard.txt from libraries do. All that's needed is more hours in the day for someone to actually implement this in the IDE.....

@ffissore ffissore modified the milestone: Release 1.6.6 Aug 4, 2015
@per1234 per1234 changed the title keywords.txt Add INPUT_PULLDOWN to keywords.txt Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE The Arduino IDE
Projects
None yet
Development

No branches or pull requests

5 participants