Skip to content

Find>Search all Sketch Tabs(checked)>Replace All - only applies to the current tab and tabs to the right of the current tab #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
per1234 opened this issue Nov 2, 2014 · 4 comments
Assignees
Labels
Component: IDE user interface The Arduino IDE's user interface Type: Bug
Milestone

Comments

@per1234
Copy link
Collaborator

per1234 commented Nov 2, 2014

Arduino IDE 1.5.8
Windows 7 64 bit

What steps will reproduce the problem?

open sketch with multiple tabs
enter text to be replaced in one of the tabs
select a tab to the right of that tab
Find
enter the text to be replaced in the Find: field
enter different text in the Replace With: field
check Search all Sketch Tabs
Replace All

What is the expected output?

all instances of the text in the Find: field in all tabs of the sketch should be replaced

What do you see instead?

only instances of the text in the Find: field in the current tab and tabs to the right of the current tab are replaced.

@matthijskooijman matthijskooijman added Component: IDE user interface The Arduino IDE's user interface Type: Bug labels Nov 3, 2014
@per1234
Copy link
Collaborator Author

per1234 commented Feb 11, 2015

This bug still exists in Arduino IDE 1.6.0

@swordmaster2k
Copy link
Contributor

I can confirm this is an issue with 1.6.0. Note that it only effects Replace All.

@swordmaster2k
Copy link
Contributor

I have identified the cause of this issue after a little debugging. The Replace All is starting at the currently selected tabs index and iterating through all of the tabs to the right.

It does not take into account that there may be any preceding tabs. I'm looking into fixing this bug so I've forked the project and branched specifically for this issue.

When Replace All is used across multiple tabs it should probably start at the first tab's index in the sketch rather than the currently selected.

This was referenced Feb 16, 2015
ffissore added a commit that referenced this issue May 26, 2015
@ffissore
Copy link
Contributor

Fixed with #2652. Available since the next hourly build

@ffissore ffissore self-assigned this May 26, 2015
@ffissore ffissore added this to the Release 1.6.5 milestone May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE user interface The Arduino IDE's user interface Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants