Please harden upload.tool property reading code for boards.txt

[kenyee]

Found out why I was getting a null pointerexception in 1.5 (now a RunnerException w/ the nightlies) when trying to integrate a different board type from 1.0 code:
processing.app.debug.RunnerException
at processing.app.debug.BasicUploader.uploadUsingPreferences(BasicUploader.java:127)
at processing.app.Sketch.upload(Sketch.java:1670)

The boards.txt file was missing some new parameters for 1.5. In particular, if the upload tool entry is not there, you'll get the runnerexception above because it tries using the BasicUploader which is now invalid because you have to use the sam one or the avrdude one:
xxx.upload.tool=avrdude
xxx.bootloader.tool=avrdude

To reproduce, take these lines out for the board you're using and try an upload to it.
It should never happen w/ a correctly specified boards.txt file, but hardening will help if people add a new board and forget all the parameters...

[LonghornEngineer]

I am getting a similar error in regards to the bootloader uploader

processing.app.debug.RunnerException
at processing.app.debug.BasicUploader.burnBootloader(BasicUploader.java:311)
at processing.app.Editor$47.run(Editor.java:2540)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[cmaglie]

Fixed the error, now a message explaining the problem appears instead of the ugly stacktrace.

Error while uploading: missing 'upload.tool' configuration parameter

Do you have something else in mind to improve this part?

C

[kenyee]

Thanks, Christian. Works for me. It was just worth making the error show something useful instead of doing something cryptic that makes you think there's a bug in the IDE instead of an issue w/ your config file ;-)