Skip to content

Extend Leonardo digital_pin_to_timer_PGM array to include the analog input pins. #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
damellis opened this issue Nov 23, 2012 · 1 comment
Closed

Extend Leonardo digital_pin_to_timer_PGM array to include the analog input pins. #1129

damellis opened this issue Nov 23, 2012 · 1 comment
Assignees
@cmaglie

Comments

@damellis
Copy link
Contributor

Currently, the digital_pin_to_timer_PGM array in variants/leonardo/pins_arduino.h doesn't include entries for the analog input pins. That can cause digitalWrite() on those pins to turn off PWM on the wrong pin, because it gets a garbage value from memory that happens to correspond to a timer. We should just extend the array to include all the pins.
@ghost ghost assigned cmaglie Nov 23, 2012
@cmaglie
Copy link
Member

cmaglie commented Nov 25, 2012

#1132

This one should fix the issue.

cmaglie added a commit that referenced this issue Nov 25, 2012
@cmaglie
Merge pull request #1132 from cmaglie/issue-1129
94ae9a7 
Extended digital_pin_to_timer_PGM array for leonardo variant. Fixes #1129
oriregev pushed a commit to oriregev/Arduino that referenced this issue Dec 20, 2013
@cmaglie
Extended digital_pin_to_timer_PGM array in variants/leonardo/pins_ard…
da9090a 
…uino.h to include analog pins (fixed arduino#1129)
oriregev pushed a commit to oriregev/Arduino that referenced this issue Dec 20, 2013
@cmaglie
Merge pull request arduino#1132 from cmaglie/issue-1129
4597d54 
Extended digital_pin_to_timer_PGM array for leonardo variant. Fixes arduino#1129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damellis @cmaglie