fix wake lockup and bus stall #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
previously requested changes
May 24, 2019
|
Apologies, I did not notice the tabs and forgot to remove the commented code. |
|
@sslupsky @per1234 the first issue is critical as it sporadically resets the processor. this PR fixed my issue (I was sleeping every second, and the process resets after about 3 hours), and I think it should be merged ASAP. If there is concern about the fix for the second issue, maybe it should be separated out? |
|
@per1234 Is this change going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses two issues:
First, there is a problem when waking from sleep that Microchip has acknowledged. To address the case a hard fault resets the device, the SysTick interrupt must be disabled.
For more information see https://www.avrfreaks.net/forum/samd21-samd21e16b-sporadically-locks-and-does-not-wake-standby-sleep-mode
The second issue is correcting the same issue described in PR #44 that exists for the setAlarmEpoch() method.