-
Notifications
You must be signed in to change notification settings - Fork 382
added method to test if time was set correctly #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
NTPClient PR arduino-libraries#71: Add method to test if time was set correctly
@per1234 are the changes done to your satisfaction? If so please let me know and I'll merge this PR. |
I signed the CLA a day ago, but it still shows "Pending". |
Frankly, no. Can you try it again? |
All requested changes have been resolved. Thanks!
Hi. I apologize to you both for my lack of response so long ago. I was out of action during that time period and never got caught up on my emails backlog after I got back to work. The changes I requested have all been made. |
Just did, it shows "You have agreed to the CLA for arduino-libraries/NTPClient" and then redirects me back to here. |
@theandy94 - you've got a github account? Seems kind of obvious but that's the error message. Are you logged in when attempting to sign the CLA? You've been using a different email address for this commit than your github account? CC @alranel |
Yes, at the bottom there is the button "Sign in with Github to agree". I sign in, then it says "You have agreed to the CLA for arduino-libraries/NTPClient" at the top. Edit: After checking my SSH key (was generated an my mac) it shows my [Mac username]@[mymac].local as email address. Edit2: Edit3: |
added method to test if time was set correctly
Allows the user to test if the NTPClient has set the time correctly.
Useful for calculations where false positives are not acceptable.
I also added a new example to present a very simple usecase for this.