Skip to content

[PXCT-768] Modulino Movement Gyroscope readings #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pedromsousalima
Copy link
Contributor

@pedromsousalima pedromsousalima commented Apr 15, 2025

Added gyro readings.
Updated basic movement example to also have these.

Copy link
Contributor

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "friendly" names for gyro measures are usually yaw, pitch, roll , I would use them in the APIs instead than "raw" x,y,z

@pedromsousalima
Copy link
Contributor Author

The "friendly" names for gyro measures are usually yaw, pitch, roll , I would use them in the APIs instead than "raw" x,y,z

Very fair. Fixed it @facchinm

@jcarolinares
Copy link

@leonardocavagnis in case you want also to take a look

Thank you guys for the review :)

@leonardocavagnis
Copy link
Contributor

@jcarolinares LGTM :)

Please, @pedromsousalima update also the docs/api.md file with new APIs
Thanks

@per1234 per1234 added the enhancement New feature or request label Apr 17, 2025
Added info on the movement modulino for angular velocity
@pedromsousalima
Copy link
Contributor Author

@jcarolinares LGTM :)

Please, @pedromsousalima update also the docs/api.md file with new APIs Thanks

Changes applied. Thank you :)

@leonardocavagnis leonardocavagnis self-requested a review April 24, 2025 13:10
@leonardocavagnis leonardocavagnis merged commit 08a4fe1 into arduino-libraries:main Apr 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants