Integrate new features #25

cristidragomir97 · 2023-11-03T16:52:10Z

This PR adds the new functionality such as:

Arduino Opta Support
Callbacks
Partitioning
Debug Output

Refactorings

github-actions · 2023-11-03T17:04:45Z

Memory usage change @ 4200218

Board	flash	%	RAM for global variables	%
`arduino:mbed_opta:opta`	🔺 +9112 - +16168	+0.46 - +0.82	🔺 +72 - +600	+0.01 - +0.11
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	🔺 +7568 - +10536	+0.36 - +0.5	❔ -32 - +16	-0.01 - 0.0

Click for full report table

Board	`extras/tests/TestExisting` flash	%	`extras/tests/TestExisting` RAM for global variables	%	`extras/tests/TestFileOperations` flash	%	`extras/tests/TestFileOperations` RAM for global variables	%	`extras/tests/TestFolderOperations` flash	%	`extras/tests/TestFolderOperations` RAM for global variables	%	`extras/tests/TestRepeatedFormatMount` flash	%	`extras/tests/TestRepeatedFormatMount` RAM for global variables	%	`examples/SimpleStorageWriteRead` flash	%	`examples/SimpleStorageWriteRead` RAM for global variables	%	`examples/AdvancedUSBInternalOperations` flash	%	`examples/AdvancedUSBInternalOperations` RAM for global variables	%	`examples/BackupInternalPartitions` flash	%	`examples/BackupInternalPartitions` RAM for global variables	%
`arduino:mbed_opta:opta`	10864	0.55	72	0.01	12424	0.63	72	0.01	11752	0.6	72	0.01	9112	0.46	72	0.01	9328	0.47	72	0.01	12520	0.64	72	0.01	16168	0.82	600	0.11
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	8752	0.42	16	0.0	10536	0.5	16	0.0	10240	0.49	16	0.0	8088	0.39	16	0.0	7568	0.36	16	0.0	10320	0.49	16	0.0	7904	0.38	-32	-0.01

Click for full report CSV

Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,10864,0.55,72,0.01,12424,0.63,72,0.01,11752,0.6,72,0.01,9112,0.46,72,0.01,9328,0.47,72,0.01,12520,0.64,72,0.01,16168,0.82,600,0.11
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,8752,0.42,16,0.0,10536,0.5,16,0.0,10240,0.49,16,0.0,8088,0.39,16,0.0,7568,0.36,16,0.0,10320,0.49,16,0.0,7904,0.38,-32,-0.01

github-actions · 2023-11-03T17:16:16Z

Memory usage change @ 26c8b0b

Board	flash	%	RAM for global variables	%
`arduino:mbed_opta:opta`	🔺 +9112 - +16168	+0.46 - +0.82	🔺 +72 - +600	+0.01 - +0.11
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	🔺 +7568 - +10536	+0.36 - +0.5	❔ -32 - +16	-0.01 - 0.0

Click for full report table

Board	`extras/tests/TestExisting` flash	%	`extras/tests/TestExisting` RAM for global variables	%	`extras/tests/TestFileOperations` flash	%	`extras/tests/TestFileOperations` RAM for global variables	%	`extras/tests/TestFolderOperations` flash	%	`extras/tests/TestFolderOperations` RAM for global variables	%	`extras/tests/TestRepeatedFormatMount` flash	%	`extras/tests/TestRepeatedFormatMount` RAM for global variables	%	`examples/SimpleStorageWriteRead` flash	%	`examples/SimpleStorageWriteRead` RAM for global variables	%	`examples/AdvancedUSBInternalOperations` flash	%	`examples/AdvancedUSBInternalOperations` RAM for global variables	%	`examples/BackupInternalPartitions` flash	%	`examples/BackupInternalPartitions` RAM for global variables	%
`arduino:mbed_opta:opta`	10864	0.55	72	0.01	12424	0.63	72	0.01	11752	0.6	72	0.01	9112	0.46	72	0.01	9328	0.47	72	0.01	12520	0.64	72	0.01	16168	0.82	600	0.11
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	8752	0.42	16	0.0	10536	0.5	16	0.0	10240	0.49	16	0.0	8088	0.39	16	0.0	7568	0.36	16	0.0	10320	0.49	16	0.0	7904	0.38	-32	-0.01

Click for full report CSV

Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,10864,0.55,72,0.01,12424,0.63,72,0.01,11752,0.6,72,0.01,9112,0.46,72,0.01,9328,0.47,72,0.01,12520,0.64,72,0.01,16168,0.82,600,0.11
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,8752,0.42,16,0.0,10536,0.5,16,0.0,10240,0.49,16,0.0,8088,0.39,16,0.0,7568,0.36,16,0.0,10320,0.49,16,0.0,7904,0.38,-32,-0.01

…ytes

sebromero

Please see comments

examples/SimpleStorageWriteRead/SimpleStorageWriteRead.ino

examples/InternalStoragePartitioning/InternalStoragePartitioning.ino

examples/SimpleStorageWriteRead/SimpleStorageWriteRead.ino

extras/tests/TestFolderOperations/TestFolderOperations.ino

library.properties

src/Arduino_UnifiedStorage.cpp

src/Utils.h

README.md

github-actions · 2023-11-08T09:31:30Z

Memory usage change @ 9089fa7

Board	flash	%	RAM for global variables	%
`arduino:mbed_opta:opta`	🔺 +9200 - +16248	+0.47 - +0.83	🔺 +72 - +600	+0.01 - +0.11
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	🔺 +7624 - +10584	+0.36 - +0.5	❔ -32 - +16	-0.01 - 0.0

Click for full report table

Board	`extras/tests/TestExisting` flash	%	`extras/tests/TestExisting` RAM for global variables	%	`extras/tests/TestFileOperations` flash	%	`extras/tests/TestFileOperations` RAM for global variables	%	`extras/tests/TestFolderOperations` flash	%	`extras/tests/TestFolderOperations` RAM for global variables	%	`extras/tests/TestRepeatedFormatMount` flash	%	`extras/tests/TestRepeatedFormatMount` RAM for global variables	%	`examples/SimpleStorageWriteRead` flash	%	`examples/SimpleStorageWriteRead` RAM for global variables	%	`examples/AdvancedUSBInternalOperations` flash	%	`examples/AdvancedUSBInternalOperations` RAM for global variables	%	`examples/BackupInternalPartitions` flash	%	`examples/BackupInternalPartitions` RAM for global variables	%
`arduino:mbed_opta:opta`	10952	0.56	72	0.01	12504	0.64	72	0.01	11776	0.6	72	0.01	9200	0.47	72	0.01	9416	0.48	72	0.01	12608	0.64	72	0.01	16248	0.83	600	0.11
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	8816	0.42	16	0.0	10584	0.5	16	0.0	10288	0.49	16	0.0	8144	0.39	16	0.0	7624	0.36	16	0.0	10376	0.49	16	0.0	7952	0.38	-32	-0.01

Click for full report CSV

Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,10952,0.56,72,0.01,12504,0.64,72,0.01,11776,0.6,72,0.01,9200,0.47,72,0.01,9416,0.48,72,0.01,12608,0.64,72,0.01,16248,0.83,600,0.11
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,8816,0.42,16,0.0,10584,0.5,16,0.0,10288,0.49,16,0.0,8144,0.39,16,0.0,7624,0.36,16,0.0,10376,0.49,16,0.0,7952,0.38,-32,-0.01

github-actions · 2023-11-08T09:39:41Z

Memory usage change @ 9948840

Board	flash	%	RAM for global variables	%
`arduino:mbed_opta:opta`	🔺 +9200 - +16248	+0.47 - +0.83	🔺 +72 - +600	+0.01 - +0.11
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	🔺 +7624 - +10584	+0.36 - +0.5	❔ -32 - +16	-0.01 - 0.0

Click for full report table

Board	`extras/tests/TestExisting` flash	%	`extras/tests/TestExisting` RAM for global variables	%	`extras/tests/TestFileOperations` flash	%	`extras/tests/TestFileOperations` RAM for global variables	%	`extras/tests/TestFolderOperations` flash	%	`extras/tests/TestFolderOperations` RAM for global variables	%	`extras/tests/TestRepeatedFormatMount` flash	%	`extras/tests/TestRepeatedFormatMount` RAM for global variables	%	`examples/SimpleStorageWriteRead` flash	%	`examples/SimpleStorageWriteRead` RAM for global variables	%	`examples/AdvancedUSBInternalOperations` flash	%	`examples/AdvancedUSBInternalOperations` RAM for global variables	%	`examples/BackupInternalPartitions` flash	%	`examples/BackupInternalPartitions` RAM for global variables	%
`arduino:mbed_opta:opta`	10952	0.56	72	0.01	12504	0.64	72	0.01	11776	0.6	72	0.01	9200	0.47	72	0.01	9416	0.48	72	0.01	12608	0.64	72	0.01	16248	0.83	600	0.11
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	8816	0.42	16	0.0	10584	0.5	16	0.0	10288	0.49	16	0.0	8144	0.39	16	0.0	7624	0.36	16	0.0	10376	0.49	16	0.0	7952	0.38	-32	-0.01

Click for full report CSV

Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,10952,0.56,72,0.01,12504,0.64,72,0.01,11776,0.6,72,0.01,9200,0.47,72,0.01,9416,0.48,72,0.01,12608,0.64,72,0.01,16248,0.83,600,0.11
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,8816,0.42,16,0.0,10584,0.5,16,0.0,10288,0.49,16,0.0,8144,0.39,16,0.0,7624,0.36,16,0.0,10376,0.49,16,0.0,7952,0.38,-32,-0.01

cristidragomir97 and others added 30 commits October 3, 2023 11:31

added opta fixes, using latest POSIXStorage lib

21e28f1

added opta logger

083b2ce

added partitioning, did 'some' refactoring

12b6e76

added full refactorings, but it fails to build for now

f783e81

fixed issues caused by refactorings

a5f54ee

Merge pull request #1 from cristidragomir97/refactorings

38f181d

Refactorings

Merge branch 'arduino-libraries:main' into main

17f9203

added readPartitions, unified Logger for C33, H7 and opta

541952e

fixed examples

02e852f

refactoring partitioning

07b405d

Improve formatting

9cd7a6e

Improve documentation

6d677f6

Refactor variable name

bb22d70

Report success only if all partitions are correctly formatted

f107ae1

Simplify code by using guard clauses

4e7931f

Rename variable

b0a5061

Remove unused code

5ee1f70

Add documentation

852ef17

Simplify code

0331227

Remove superfluous empty lines

7024428

Simplify code by using guard clauses

df9c8b6

Fix compiler warnings

2ce00cd

Revert calls to printToSerialOrRS485

6103551

Use board config instead of custom defines

3d332ea

Fix spelling mistakes

dd83662

Add missing return statements

be4f8b0

Fix incorrect reference

99ffb53

Replace printToSerialOrRS485 with debugPrint

688059b

Add missing import

1940f36

Use Boards file instead of redefining board features

1821d32

cristidragomir97 added 10 commits October 27, 2023 19:04

updated RS485 dependency in github action

817aeae

fixes and tweaks

943a875

added debugPrint statements everywhere

ac8699a

fixed warningins

2ea7e0c

fixed bug on first-time internal storage usage

722bf6e

implemented static bool for logging

9f2b611

fixed logging

7f2e8e3

cleaned up examples, fixed RS485, fixed spelling errors

3b5be8d

updated readme and docs

4200218

Update README.md

26c8b0b

per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 3, 2023

cristidragomir97 added 2 commits November 6, 2023 12:48

Update Partitioning.cpp to skip partitions of 0x0B type that have 0 b…

3a80cc5

…ytes

Update Partitioning.cpp to avoid empty partitions

08910eb

sebromero requested review from sebromero and aliphys November 7, 2023 08:53

sebromero requested changes Nov 7, 2023

View reviewed changes

Readme improvements

50fb1fc

aliphys reviewed Nov 7, 2023

View reviewed changes

README.md Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

cristidragomir97 and others added 4 commits November 7, 2023 16:43

cosmetic and consistency fixes

b5b21e1

Merge branch 'main' into partitioning_callbacks_opta

9089fa7

Change storage variable name in example

a10bdc8

Bump version number

9948840

sebromero approved these changes Nov 8, 2023

View reviewed changes

sebromero merged commit cdf11bd into main Nov 8, 2023

sebromero deleted the partitioning_callbacks_opta branch November 8, 2023 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate new features #25

Integrate new features #25

cristidragomir97 commented Nov 3, 2023

github-actions bot commented Nov 3, 2023

github-actions bot commented Nov 3, 2023

sebromero left a comment

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 8, 2023

Integrate new features #25

Integrate new features #25

Conversation

cristidragomir97 commented Nov 3, 2023

github-actions bot commented Nov 3, 2023

github-actions bot commented Nov 3, 2023

sebromero left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 8, 2023