Skip to content

Use the Compile Examples workflow for the deltas report #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Use the Compile Examples workflow for the deltas report #16

merged 1 commit into from
Oct 15, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Oct 15, 2020

Using a scheduled workflow for the size deltas report is not appropriate in private repositories because it uses a lot
of minutes and, unlike public repositories, private repositories have a limited allotment of free GitHub Actions
minutes.

The report-size-deltas job is configured for use in private repositories which don't have the "Send write tokens to
workflows from fork pull requests" setting enabled. This means that PRs submitted from forks won't get size deltas
reports. If reports on PRs from forks are wanted, the repository can be configured to provide them with write tokens and
the workflow adjusted so the job will run on PRs from forks

Once the repository is made public, the workflow should be reconfigured to provide size deltas reports on PRs from
forks.

More information:
https://github.com/arduino/report-size-deltas#sketches-reports-source

Using a scheduled workflow for the size deltas report is not appropriate in private repositories because it uses a lot
of minutes and, unlike public repositories, private repositories have a limited allotment of free GitHub Actions
minutes.

The `report-size-deltas` job is configured for use in private repositories which don't have the "Send write tokens to
workflows from fork pull requests" setting enabled. This means that PRs submitted from forks won't get size deltas
reports. If reports on PRs from forks are wanted, the repository can be configured to provide them with write tokens and
the workflow adjusted so the job will run on PRs from forks

Once the repository is made public, the workflow should be reconfigured to provide size deltas reports on PRs from
forks.

More information:
https://github.com/arduino/report-size-deltas#sketches-reports-source
@per1234 per1234 merged commit 8e2a3c6 into arduino-libraries:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant