Skip to content

Add CI workflow #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 15, 2020
Merged

Add CI workflow #13

merged 17 commits into from
Oct 15, 2020

Conversation

giulcioffi
Copy link
Contributor

Add compile-examples and report-size-deltas workflows for CI.
The compile-examples workflow downloads the modified cli version from https://downloads.arduino.cc/arduino-cli/arduino-cli_arduino_threads_Linux_64bit.tar.gz by setting
cli-version: 'arduino_threads' .
All the examples provided by this library are compiled for boards

  • Nano 33 BLE
  • Envie m7

Minor fixes have been applied to few sketches in order to make them compile with the latest version of ArduinoThreads library.

run: |
mv "${{ env.ARDUINOCORE_API_STAGING_PATH }}/api" "${{ env.ARDUINOCORE_MBED_STAGING_PATH }}/cores/arduino"
- name: Compile examples
uses: arduino/actions/libraries/compile-examples@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: arduino/actions/libraries/compile-examples@master
uses: arduino/compile-sketches@main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) done!

@giulcioffi giulcioffi requested a review from per1234 October 12, 2020 09:45
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting to see the action working with the first .inot sketches!

I made a couple minor suggestions for the workflow, but it looks great as-is.

giulcioffi and others added 2 commits October 13, 2020 09:50
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beta phase arduino-beta:mbed boards platform of the Portenta H7 has been deprecated, which will cause platform installation during the compilation check CI to fail if the old name is used.

Reference: arduino/ArduinoCore-mbed#72

@facchinm facchinm merged commit 9aab1ae into arduino-libraries:master Oct 15, 2020
@aentinger aentinger deleted the CIworkflow branch November 2, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants