Skip to content

Add support for ethernet interface #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Jul 27, 2022

This PR enables the use of ethernet interface for the download process of the OTA binary.

Certificates used for download are stored in the /wlan partition of the QSPI flash and this partition is mounted only if WiFi interface is used, so i've added two steps in the begin function to initialize the /wlan partition and check if certificates are present.

@pennam pennam requested review from aentinger and facchinm July 27, 2022 08:02
@github-actions
Copy link

Memory usage change @ 53437f5

Board flash % RAM for global variables %
arduino:mbed:envie_m7 🔺 0 - +336 0.0 - +0.04 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +240 0.0 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/OTA_Qspi_Flash
flash
% examples/OTA_Qspi_Flash
RAM for global variables
% examples/OTA_SD_Portenta
flash
% examples/OTA_SD_Portenta
RAM for global variables
% examples/OTA_Usage_Portenta
flash
% examples/OTA_Usage_Portenta
RAM for global variables
%
arduino:mbed:envie_m7 304 0.04 0 0.0 336 0.04 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 240 0.01 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/OTA_Qspi_Flash<br>flash,%,examples/OTA_Qspi_Flash<br>RAM for global variables,%,examples/OTA_SD_Portenta<br>flash,%,examples/OTA_SD_Portenta<br>RAM for global variables,%,examples/OTA_Usage_Portenta<br>flash,%,examples/OTA_Usage_Portenta<br>RAM for global variables,%
arduino:mbed:envie_m7,304,0.04,0,0.0,336,0.04,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,240,0.01,0,0.0,,,,,0,0.0,0,0.0

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pennam pennam merged commit 5dd7cf0 into arduino-libraries:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants