Skip to content

Redirect error prints to Serial #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2022
Merged

Redirect error prints to Serial #28

merged 2 commits into from
Jul 25, 2022

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Jul 22, 2022

This library used to print errors on Serial1. Thei PR includes Arduino_DebugUtils to move them to Serial and standardize prints format.

@github-actions
Copy link

Memory usage change @ 348300a

Board flash % RAM for global variables %
arduino:mbed:envie_m7 🔺 0 - +584 0.0 - +0.07 🔺 0 - +16 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +592 0.0 - +0.03 🔺 0 - +16 0.0 - 0.0
Click for full report table
Board examples/OTA_Qspi_Flash
flash		 % examples/OTA_Qspi_Flash
RAM for global variables		 % examples/OTA_SD_Portenta
flash		 % examples/OTA_SD_Portenta
RAM for global variables		 % examples/OTA_Usage_Portenta
flash		 % examples/OTA_Usage_Portenta
RAM for global variables		 %
arduino:mbed:envie_m7 520 0.07 16 0.0 584 0.07 16 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 592 0.03 16 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/OTA_Qspi_Flash<br>flash,%,examples/OTA_Qspi_Flash<br>RAM for global variables,%,examples/OTA_SD_Portenta<br>flash,%,examples/OTA_SD_Portenta<br>RAM for global variables,%,examples/OTA_Usage_Portenta<br>flash,%,examples/OTA_Usage_Portenta<br>RAM for global variables,%
arduino:mbed:envie_m7,520,0.07,16,0.0,584,0.07,16,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,592,0.03,16,0.0,,,,,0,0.0,0,0.0

@pennam pennam requested review from facchinm and aentinger July 22, 2022 13:13
aentinger
aentinger approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pennam pennam merged commit b504877 into arduino-libraries:main Jul 25, 2022
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pennam @aentinger @per1234