Move to default_instance QSPIF #13
Conversation
|
Memory usage change @ 439c3e2
Click for full report table
Click for full report CSV |
|
@manchoz is this still needed? |
manchoz
force-pushed
the
qspif_default_instance
branch
from
439c3e2 to
d0f4141
Compare
|
Memory usage change @ d0f4141
Click for full report table
Click for full report CSV |
|
@pennam yes, it is! It is needed for all the scenarios where OTA needs to be done via media other than WiFi (USB, Ethernet, etc.). When |
manchoz
changed the title
|
@pennam please, review. |
There was a problem hiding this comment.
@manchoz could you please have a look to this commit pennam@7f37a53 ? Doing like this we are keeping compatibility with older core versions and using get_default_instance() for the new ones. I've also added a call to the init() method.
| @@ -47,13 +43,7 @@ Arduino_Portenta_OTA_QSPI::Arduino_Portenta_OTA_QSPI(StorageTypePortenta const s | |||
|
|
|||
| bool Arduino_Portenta_OTA_QSPI::init() | |||
| { | |||
| #if !defined (COMPONENT_4343W_FS) | |||
| qspi_bd = new QSPIFBlockDevice(PD_11, PD_12, PF_7, PD_13, PF_10, PG_6, QSPIF_POLARITY_MODE_1, 40000000); | |||
There was a problem hiding this comment.
If we remove completely this line we are dropping compatibility for older core versions ( < 2.3.1 )
| return false; | ||
| } | ||
| #endif | ||
| auto qspi_bd = mbed::BlockDevice::get_default_instance(); |
There was a problem hiding this comment.
In theory we still need to call the init function here, even if we are using get_default_instance()
|
superseded by #21 |
No description provided.