Skip to content

Separation of RTD and TC classes confusing #14

Closed as not planned
Closed as not planned
@JHSawatzki

Description

@JHSawatzki

Both probe types use the same inputs/channels so the current implementation is confusing, espacially when using both types in the same project.

I suggest using a shared class like I did in my fork of the old lib, see https://github.com/JHSawatzki/Arduino_MachineControl/blob/master/src/Arduino_MachineControl.h

I could probably also provide a pull request with an implementation not breaking your current API.

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic: codeRelated to content of the project itselftype: enhancementProposed improvement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions