Skip to content

Rename variable matrix to ledMatrixAnimationHandler #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

fabik111
Copy link
Collaborator

This PR fixes the clashing issue with the variable matrix of UNO R4

@fabik111 fabik111 requested a review from pennam May 27, 2025 08:39
Copy link
Collaborator

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for CI and :shipit:

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (b349c5d) to head (9c50c4a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files           7        7           
  Lines         713      713           
  Branches       86       86           
=======================================
  Hits          642      642           
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fabik111 fabik111 merged commit 92176b0 into main May 27, 2025
31 checks passed
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 28, 2025
@fabik111 fabik111 deleted the fix-name-clashing-matrix branch May 28, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants