Skip to content

Fix Display issue #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2022
Merged

Fix Display issue #52

merged 3 commits into from
Jun 9, 2022

Conversation

marqdevx
Copy link
Member

  • Display constructor fixed to last version updates, discover issue with display.println()
  • Fix LEDs RGB order to RGB instead of BGR
  • Bump version correctly (didnt do it in the latest release)

@marqdevx marqdevx requested a review from aentinger May 24, 2022 09:33
@marqdevx marqdevx self-assigned this May 24, 2022
@marqdevx marqdevx requested a review from Rocketct May 24, 2022 09:35
@github-actions
Copy link

Memory usage change @ d95c0a3

Board flash % RAM for global variables %
arduino:samd:mkrwifi1010 🔺 +16 - +16 +0.01 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Actuators/Buzzer_Melody
flash		 % examples/Actuators/Buzzer_Melody
RAM for global variables		 % examples/Actuators/Relays_blink
flash		 % examples/Actuators/Relays_blink
RAM for global variables		 % examples/All_Features
flash		 % examples/All_Features
RAM for global variables		 % examples/Grove_Inputs
flash		 % examples/Grove_Inputs
RAM for global variables		 % examples/LEDs-Examples/strandtest
flash		 % examples/LEDs-Examples/strandtest
RAM for global variables		 % examples/SD_card
flash		 % examples/SD_card
RAM for global variables		 % examples/Sensors/ENV-HTS221/ReadSensors
flash		 % examples/Sensors/ENV-HTS221/ReadSensors
RAM for global variables		 % examples/Sensors/ENV-HTS221/ReadSensorsImperial
flash		 % examples/Sensors/ENV-HTS221/ReadSensorsImperial
RAM for global variables		 % examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer
flash		 % examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer
RAM for global variables		 % examples/Sensors/IMU-LSM6DS3/SimpleGyroscope
flash		 % examples/Sensors/IMU-LSM6DS3/SimpleGyroscope
RAM for global variables		 % examples/Sensors/Light-APDS9960/FullExample
flash		 % examples/Sensors/Light-APDS9960/FullExample
RAM for global variables		 % examples/Sensors/Light-APDS9960/GestureSensor
flash		 % examples/Sensors/Light-APDS9960/GestureSensor
RAM for global variables		 % examples/Sensors/Light-APDS9960/ProximitySensor
flash		 % examples/Sensors/Light-APDS9960/ProximitySensor
RAM for global variables		 % examples/Sensors/Light-APDS9960/Read_Colors
flash		 % examples/Sensors/Light-APDS9960/Read_Colors
RAM for global variables		 % examples/Sensors/Pressure-LPS22HB/ReadPressure
flash		 % examples/Sensors/Pressure-LPS22HB/ReadPressure
RAM for global variables		 % examples/Sensors/Pressure-LPS22HB/ReadPressureImperial
flash		 % examples/Sensors/Pressure-LPS22HB/ReadPressureImperial
RAM for global variables		 % examples/TouchPads/Custom_Sensitivity
flash		 % examples/TouchPads/Custom_Sensitivity
RAM for global variables		 % examples/TouchPads/Relays_control_Qtouch
flash		 % examples/TouchPads/Relays_control_Qtouch
RAM for global variables		 % examples/TouchPads/TouchTypes
flash		 % examples/TouchPads/TouchTypes
RAM for global variables		 % examples/TouchPads/Touch_and_LEDs
flash		 % examples/TouchPads/Touch_and_LEDs
RAM for global variables		 % examples/TouchPads/Touch_signals
flash		 % examples/TouchPads/Touch_signals
RAM for global variables		 % examples/TouchPads/getTouch
flash		 % examples/TouchPads/getTouch
RAM for global variables		 % examples/Display/Compose_images
flash		 % examples/Display/Compose_images
RAM for global variables		 % examples/Display/Graphics
flash		 % examples/Display/Graphics
RAM for global variables		 %
arduino:samd:mkrwifi1010 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
Click for full report CSV 
Board,examples/Actuators/Buzzer_Melody<br>flash,%,examples/Actuators/Buzzer_Melody<br>RAM for global variables,%,examples/Actuators/Relays_blink<br>flash,%,examples/Actuators/Relays_blink<br>RAM for global variables,%,examples/All_Features<br>flash,%,examples/All_Features<br>RAM for global variables,%,examples/Grove_Inputs<br>flash,%,examples/Grove_Inputs<br>RAM for global variables,%,examples/LEDs-Examples/strandtest<br>flash,%,examples/LEDs-Examples/strandtest<br>RAM for global variables,%,examples/SD_card<br>flash,%,examples/SD_card<br>RAM for global variables,%,examples/Sensors/ENV-HTS221/ReadSensors<br>flash,%,examples/Sensors/ENV-HTS221/ReadSensors<br>RAM for global variables,%,examples/Sensors/ENV-HTS221/ReadSensorsImperial<br>flash,%,examples/Sensors/ENV-HTS221/ReadSensorsImperial<br>RAM for global variables,%,examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer<br>flash,%,examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer<br>RAM for global variables,%,examples/Sensors/IMU-LSM6DS3/SimpleGyroscope<br>flash,%,examples/Sensors/IMU-LSM6DS3/SimpleGyroscope<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/FullExample<br>flash,%,examples/Sensors/Light-APDS9960/FullExample<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/GestureSensor<br>flash,%,examples/Sensors/Light-APDS9960/GestureSensor<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/ProximitySensor<br>flash,%,examples/Sensors/Light-APDS9960/ProximitySensor<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/Read_Colors<br>flash,%,examples/Sensors/Light-APDS9960/Read_Colors<br>RAM for global variables,%,examples/Sensors/Pressure-LPS22HB/ReadPressure<br>flash,%,examples/Sensors/Pressure-LPS22HB/ReadPressure<br>RAM for global variables,%,examples/Sensors/Pressure-LPS22HB/ReadPressureImperial<br>flash,%,examples/Sensors/Pressure-LPS22HB/ReadPressureImperial<br>RAM for global variables,%,examples/TouchPads/Custom_Sensitivity<br>flash,%,examples/TouchPads/Custom_Sensitivity<br>RAM for global variables,%,examples/TouchPads/Relays_control_Qtouch<br>flash,%,examples/TouchPads/Relays_control_Qtouch<br>RAM for global variables,%,examples/TouchPads/TouchTypes<br>flash,%,examples/TouchPads/TouchTypes<br>RAM for global variables,%,examples/TouchPads/Touch_and_LEDs<br>flash,%,examples/TouchPads/Touch_and_LEDs<br>RAM for global variables,%,examples/TouchPads/Touch_signals<br>flash,%,examples/TouchPads/Touch_signals<br>RAM for global variables,%,examples/TouchPads/getTouch<br>flash,%,examples/TouchPads/getTouch<br>RAM for global variables,%,examples/Display/Compose_images<br>flash,%,examples/Display/Compose_images<br>RAM for global variables,%,examples/Display/Graphics<br>flash,%,examples/Display/Graphics<br>RAM for global variables,%
arduino:samd:mkrwifi1010,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0

per1234
per1234 previously requested changes May 24, 2022
View reviewed changes
@github-actions
Copy link

Memory usage change @ 548f453

Board flash % RAM for global variables %
arduino:samd:mkrwifi1010 🔺 +16 - +16 +0.01 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Actuators/Buzzer_Melody
flash		 % examples/Actuators/Buzzer_Melody
RAM for global variables		 % examples/Actuators/Relays_blink
flash		 % examples/Actuators/Relays_blink
RAM for global variables		 % examples/All_Features
flash		 % examples/All_Features
RAM for global variables		 % examples/Grove_Inputs
flash		 % examples/Grove_Inputs
RAM for global variables		 % examples/LEDs-Examples/strandtest
flash		 % examples/LEDs-Examples/strandtest
RAM for global variables		 % examples/SD_card
flash		 % examples/SD_card
RAM for global variables		 % examples/Sensors/ENV-HTS221/ReadSensors
flash		 % examples/Sensors/ENV-HTS221/ReadSensors
RAM for global variables		 % examples/Sensors/ENV-HTS221/ReadSensorsImperial
flash		 % examples/Sensors/ENV-HTS221/ReadSensorsImperial
RAM for global variables		 % examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer
flash		 % examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer
RAM for global variables		 % examples/Sensors/IMU-LSM6DS3/SimpleGyroscope
flash		 % examples/Sensors/IMU-LSM6DS3/SimpleGyroscope
RAM for global variables		 % examples/Sensors/Light-APDS9960/FullExample
flash		 % examples/Sensors/Light-APDS9960/FullExample
RAM for global variables		 % examples/Sensors/Light-APDS9960/GestureSensor
flash		 % examples/Sensors/Light-APDS9960/GestureSensor
RAM for global variables		 % examples/Sensors/Light-APDS9960/ProximitySensor
flash		 % examples/Sensors/Light-APDS9960/ProximitySensor
RAM for global variables		 % examples/Sensors/Light-APDS9960/Read_Colors
flash		 % examples/Sensors/Light-APDS9960/Read_Colors
RAM for global variables		 % examples/Sensors/Pressure-LPS22HB/ReadPressure
flash		 % examples/Sensors/Pressure-LPS22HB/ReadPressure
RAM for global variables		 % examples/Sensors/Pressure-LPS22HB/ReadPressureImperial
flash		 % examples/Sensors/Pressure-LPS22HB/ReadPressureImperial
RAM for global variables		 % examples/TouchPads/Custom_Sensitivity
flash		 % examples/TouchPads/Custom_Sensitivity
RAM for global variables		 % examples/TouchPads/Relays_control_Qtouch
flash		 % examples/TouchPads/Relays_control_Qtouch
RAM for global variables		 % examples/TouchPads/TouchTypes
flash		 % examples/TouchPads/TouchTypes
RAM for global variables		 % examples/TouchPads/Touch_and_LEDs
flash		 % examples/TouchPads/Touch_and_LEDs
RAM for global variables		 % examples/TouchPads/Touch_signals
flash		 % examples/TouchPads/Touch_signals
RAM for global variables		 % examples/TouchPads/getTouch
flash		 % examples/TouchPads/getTouch
RAM for global variables		 % examples/Display/Compose_images
flash		 % examples/Display/Compose_images
RAM for global variables		 % examples/Display/Graphics
flash		 % examples/Display/Graphics
RAM for global variables		 %
arduino:samd:mkrwifi1010 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
Click for full report CSV 
Board,examples/Actuators/Buzzer_Melody<br>flash,%,examples/Actuators/Buzzer_Melody<br>RAM for global variables,%,examples/Actuators/Relays_blink<br>flash,%,examples/Actuators/Relays_blink<br>RAM for global variables,%,examples/All_Features<br>flash,%,examples/All_Features<br>RAM for global variables,%,examples/Grove_Inputs<br>flash,%,examples/Grove_Inputs<br>RAM for global variables,%,examples/LEDs-Examples/strandtest<br>flash,%,examples/LEDs-Examples/strandtest<br>RAM for global variables,%,examples/SD_card<br>flash,%,examples/SD_card<br>RAM for global variables,%,examples/Sensors/ENV-HTS221/ReadSensors<br>flash,%,examples/Sensors/ENV-HTS221/ReadSensors<br>RAM for global variables,%,examples/Sensors/ENV-HTS221/ReadSensorsImperial<br>flash,%,examples/Sensors/ENV-HTS221/ReadSensorsImperial<br>RAM for global variables,%,examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer<br>flash,%,examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer<br>RAM for global variables,%,examples/Sensors/IMU-LSM6DS3/SimpleGyroscope<br>flash,%,examples/Sensors/IMU-LSM6DS3/SimpleGyroscope<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/FullExample<br>flash,%,examples/Sensors/Light-APDS9960/FullExample<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/GestureSensor<br>flash,%,examples/Sensors/Light-APDS9960/GestureSensor<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/ProximitySensor<br>flash,%,examples/Sensors/Light-APDS9960/ProximitySensor<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/Read_Colors<br>flash,%,examples/Sensors/Light-APDS9960/Read_Colors<br>RAM for global variables,%,examples/Sensors/Pressure-LPS22HB/ReadPressure<br>flash,%,examples/Sensors/Pressure-LPS22HB/ReadPressure<br>RAM for global variables,%,examples/Sensors/Pressure-LPS22HB/ReadPressureImperial<br>flash,%,examples/Sensors/Pressure-LPS22HB/ReadPressureImperial<br>RAM for global variables,%,examples/TouchPads/Custom_Sensitivity<br>flash,%,examples/TouchPads/Custom_Sensitivity<br>RAM for global variables,%,examples/TouchPads/Relays_control_Qtouch<br>flash,%,examples/TouchPads/Relays_control_Qtouch<br>RAM for global variables,%,examples/TouchPads/TouchTypes<br>flash,%,examples/TouchPads/TouchTypes<br>RAM for global variables,%,examples/TouchPads/Touch_and_LEDs<br>flash,%,examples/TouchPads/Touch_and_LEDs<br>RAM for global variables,%,examples/TouchPads/Touch_signals<br>flash,%,examples/TouchPads/Touch_signals<br>RAM for global variables,%,examples/TouchPads/getTouch<br>flash,%,examples/TouchPads/getTouch<br>RAM for global variables,%,examples/Display/Compose_images<br>flash,%,examples/Display/Compose_images<br>RAM for global variables,%,examples/Display/Graphics<br>flash,%,examples/Display/Graphics<br>RAM for global variables,%
arduino:samd:mkrwifi1010,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0

@marqdevx marqdevx force-pushed the marqdevx/external-libs-fix branch from 548f453 to bdbe4ea Compare May 24, 2022 14:41
@github-actions
Copy link

Memory usage change @ bdbe4ea

Board flash % RAM for global variables %
arduino:samd:mkrwifi1010 🔺 +16 - +16 +0.01 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Actuators/Buzzer_Melody
flash		 % examples/Actuators/Buzzer_Melody
RAM for global variables		 % examples/Actuators/Relays_blink
flash		 % examples/Actuators/Relays_blink
RAM for global variables		 % examples/All_Features
flash		 % examples/All_Features
RAM for global variables		 % examples/Grove_Inputs
flash		 % examples/Grove_Inputs
RAM for global variables		 % examples/LEDs-Examples/strandtest
flash		 % examples/LEDs-Examples/strandtest
RAM for global variables		 % examples/SD_card
flash		 % examples/SD_card
RAM for global variables		 % examples/Sensors/ENV-HTS221/ReadSensors
flash		 % examples/Sensors/ENV-HTS221/ReadSensors
RAM for global variables		 % examples/Sensors/ENV-HTS221/ReadSensorsImperial
flash		 % examples/Sensors/ENV-HTS221/ReadSensorsImperial
RAM for global variables		 % examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer
flash		 % examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer
RAM for global variables		 % examples/Sensors/IMU-LSM6DS3/SimpleGyroscope
flash		 % examples/Sensors/IMU-LSM6DS3/SimpleGyroscope
RAM for global variables		 % examples/Sensors/Light-APDS9960/FullExample
flash		 % examples/Sensors/Light-APDS9960/FullExample
RAM for global variables		 % examples/Sensors/Light-APDS9960/GestureSensor
flash		 % examples/Sensors/Light-APDS9960/GestureSensor
RAM for global variables		 % examples/Sensors/Light-APDS9960/ProximitySensor
flash		 % examples/Sensors/Light-APDS9960/ProximitySensor
RAM for global variables		 % examples/Sensors/Light-APDS9960/Read_Colors
flash		 % examples/Sensors/Light-APDS9960/Read_Colors
RAM for global variables		 % examples/Sensors/Pressure-LPS22HB/ReadPressure
flash		 % examples/Sensors/Pressure-LPS22HB/ReadPressure
RAM for global variables		 % examples/Sensors/Pressure-LPS22HB/ReadPressureImperial
flash		 % examples/Sensors/Pressure-LPS22HB/ReadPressureImperial
RAM for global variables		 % examples/TouchPads/Custom_Sensitivity
flash		 % examples/TouchPads/Custom_Sensitivity
RAM for global variables		 % examples/TouchPads/Relays_control_Qtouch
flash		 % examples/TouchPads/Relays_control_Qtouch
RAM for global variables		 % examples/TouchPads/TouchTypes
flash		 % examples/TouchPads/TouchTypes
RAM for global variables		 % examples/TouchPads/Touch_and_LEDs
flash		 % examples/TouchPads/Touch_and_LEDs
RAM for global variables		 % examples/TouchPads/Touch_signals
flash		 % examples/TouchPads/Touch_signals
RAM for global variables		 % examples/TouchPads/getTouch
flash		 % examples/TouchPads/getTouch
RAM for global variables		 % examples/Display/Compose_images
flash		 % examples/Display/Compose_images
RAM for global variables		 % examples/Display/Graphics
flash		 % examples/Display/Graphics
RAM for global variables		 %
arduino:samd:mkrwifi1010 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0
Click for full report CSV 
Board,examples/Actuators/Buzzer_Melody<br>flash,%,examples/Actuators/Buzzer_Melody<br>RAM for global variables,%,examples/Actuators/Relays_blink<br>flash,%,examples/Actuators/Relays_blink<br>RAM for global variables,%,examples/All_Features<br>flash,%,examples/All_Features<br>RAM for global variables,%,examples/Grove_Inputs<br>flash,%,examples/Grove_Inputs<br>RAM for global variables,%,examples/LEDs-Examples/strandtest<br>flash,%,examples/LEDs-Examples/strandtest<br>RAM for global variables,%,examples/SD_card<br>flash,%,examples/SD_card<br>RAM for global variables,%,examples/Sensors/ENV-HTS221/ReadSensors<br>flash,%,examples/Sensors/ENV-HTS221/ReadSensors<br>RAM for global variables,%,examples/Sensors/ENV-HTS221/ReadSensorsImperial<br>flash,%,examples/Sensors/ENV-HTS221/ReadSensorsImperial<br>RAM for global variables,%,examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer<br>flash,%,examples/Sensors/IMU-LSM6DS3/SimpleAccelerometer<br>RAM for global variables,%,examples/Sensors/IMU-LSM6DS3/SimpleGyroscope<br>flash,%,examples/Sensors/IMU-LSM6DS3/SimpleGyroscope<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/FullExample<br>flash,%,examples/Sensors/Light-APDS9960/FullExample<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/GestureSensor<br>flash,%,examples/Sensors/Light-APDS9960/GestureSensor<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/ProximitySensor<br>flash,%,examples/Sensors/Light-APDS9960/ProximitySensor<br>RAM for global variables,%,examples/Sensors/Light-APDS9960/Read_Colors<br>flash,%,examples/Sensors/Light-APDS9960/Read_Colors<br>RAM for global variables,%,examples/Sensors/Pressure-LPS22HB/ReadPressure<br>flash,%,examples/Sensors/Pressure-LPS22HB/ReadPressure<br>RAM for global variables,%,examples/Sensors/Pressure-LPS22HB/ReadPressureImperial<br>flash,%,examples/Sensors/Pressure-LPS22HB/ReadPressureImperial<br>RAM for global variables,%,examples/TouchPads/Custom_Sensitivity<br>flash,%,examples/TouchPads/Custom_Sensitivity<br>RAM for global variables,%,examples/TouchPads/Relays_control_Qtouch<br>flash,%,examples/TouchPads/Relays_control_Qtouch<br>RAM for global variables,%,examples/TouchPads/TouchTypes<br>flash,%,examples/TouchPads/TouchTypes<br>RAM for global variables,%,examples/TouchPads/Touch_and_LEDs<br>flash,%,examples/TouchPads/Touch_and_LEDs<br>RAM for global variables,%,examples/TouchPads/Touch_signals<br>flash,%,examples/TouchPads/Touch_signals<br>RAM for global variables,%,examples/TouchPads/getTouch<br>flash,%,examples/TouchPads/getTouch<br>RAM for global variables,%,examples/Display/Compose_images<br>flash,%,examples/Display/Compose_images<br>RAM for global variables,%,examples/Display/Graphics<br>flash,%,examples/Display/Graphics<br>RAM for global variables,%
arduino:samd:mkrwifi1010,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0

@per1234 per1234 dismissed their stale review May 24, 2022 15:18

My concern has been addressed. Thanks!

@marqdevx marqdevx changed the title Fix Display issue and LEDs' order to RGB Fix Display issue May 25, 2022
ubidefeo
ubidefeo approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marqdevx marqdevx merged commit 02a9ff3 into master Jun 9, 2022
@per1234 per1234 deleted the marqdevx/external-libs-fix branch March 16, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

@ubidefeo ubidefeo ubidefeo approved these changes

@aentinger aentinger Awaiting requested review from aentinger

@Rocketct Rocketct Awaiting requested review from Rocketct

Assignees

@marqdevx marqdevx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marqdevx @ubidefeo @per1234