Skip to content

Fixed Relays #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Fixed Relays #35

merged 1 commit into from
Jul 23, 2021

Conversation

ubidefeo
Copy link
Contributor

I have had reports from a user in a FB group about the Relay_blink example not working and I verified it didn't.
I ended up adding a begin() method to the MRKIOTCarrier_Relay Class to set the pinMode().
The MKRIoTCarrier::begin() method now invokes these for Relay_1 and Relay_2.
Also set the _pin private member in the initializer list to make it const int.

Tested and working, but please run your tests

@marqdevx
Copy link
Member

LGTM

@marqdevx marqdevx merged commit 70134c1 into arduino-libraries:master Jul 23, 2021
@ubidefeo ubidefeo deleted the fixRelays branch July 24, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants