Skip to content

Add unsigned long support; addresses issues #39 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

dirkx
Copy link
Contributor

@dirkx dirkx commented Oct 27, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Memory usage change @ e8f2289

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 0 - +454 0.0 - +1.58 🔺 0 - +8 0.0 - +0.31
arduino:avr:mega 🔺 0 - +456 0.0 - +0.18 🔺 0 - +10 0.0 - +0.12
arduino:avr:nano 🔺 0 - +456 0.0 - +1.48 🔺 0 - +10 0.0 - +0.49
arduino:avr:yun 🔺 0 - +454 0.0 - +1.58 🔺 0 - +8 0.0 - +0.31
arduino:mbed_edge:edge_control 🔺 0 - +5464 0.0 - +0.56 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 🔺 0 - +5456 0.0 - +0.56 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +431 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m4 🔺 0 - +3856 0.0 - +0.37 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 🔺 0 - +3848 0.0 - +0.49 0 - 0 0.0 - 0.0
arduino:megaavr:nona4809 🔺 0 - +455 0.0 - +0.93 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018 🔺 0 - +455 0.0 - +0.94 0 - 0 0.0 - 0.0
arduino:sam:arduino_due_x_dbg 🔺 0 - +7040 0.0 - +1.34 N/A N/A
arduino:samd:arduino_zero_edbg 🔺 0 - +3308 0.0 - +1.26 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 🔺 0 - +3308 0.0 - +1.26 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +3308 0.0 - +1.26 0 - 0 0.0 - 0.0
Click for full report table
Board examples/JSONArray
flash
% examples/JSONArray
RAM for global variables
% examples/JSONKitchenSink
flash
% examples/JSONKitchenSink
RAM for global variables
% examples/JSONObject
flash
% examples/JSONObject
RAM for global variables
%
arduino:avr:leonardo 0 0.0 0 0.0 0 0.0 0 0.0 454 1.58 8 0.31
arduino:avr:mega 0 0.0 0 0.0 0 0.0 0 0.0 456 0.18 10 0.12
arduino:avr:nano 0 0.0 0 0.0 0 0.0 0 0.0 456 1.48 10 0.49
arduino:avr:yun 0 0.0 0 0.0 0 0.0 0 0.0 454 1.58 8 0.31
arduino:mbed_edge:edge_control 0 0.0 0 0.0 0 0.0 0 0.0 5464 0.56 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 5456 0.56 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 431 0.0 0 0.0
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 3856 0.37 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 3848 0.49 0 0.0
arduino:megaavr:nona4809 0 0.0 0 0.0 0 0.0 0 0.0 455 0.93 0 0.0
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0 455 0.94 0 0.0
arduino:sam:arduino_due_x_dbg 0 0.0 N/A N/A 0 0.0 N/A N/A 7040 1.34 N/A N/A
arduino:samd:arduino_zero_edbg 0 0.0 0 0.0 0 0.0 0 0.0 3308 1.26 0 0.0
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 3308 1.26 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 0 0.0 0 0.0 3308 1.26 0 0.0
Click for full report CSV
Board,examples/JSONArray<br>flash,%,examples/JSONArray<br>RAM for global variables,%,examples/JSONKitchenSink<br>flash,%,examples/JSONKitchenSink<br>RAM for global variables,%,examples/JSONObject<br>flash,%,examples/JSONObject<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0,0,0.0,0,0.0,454,1.58,8,0.31
arduino:avr:mega,0,0.0,0,0.0,0,0.0,0,0.0,456,0.18,10,0.12
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,456,1.48,10,0.49
arduino:avr:yun,0,0.0,0,0.0,0,0.0,0,0.0,454,1.58,8,0.31
arduino:mbed_edge:edge_control,0,0.0,0,0.0,0,0.0,0,0.0,5464,0.56,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,5456,0.56,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,431,0.0,0,0.0
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,3856,0.37,0,0.0
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,3848,0.49,0,0.0
arduino:megaavr:nona4809,0,0.0,0,0.0,0,0.0,0,0.0,455,0.93,0,0.0
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0,455,0.94,0,0.0
arduino:sam:arduino_due_x_dbg,0,0.0,N/A,N/A,0,0.0,N/A,N/A,7040,1.34,N/A,N/A
arduino:samd:arduino_zero_edbg,0,0.0,0,0.0,0,0.0,0,0.0,3308,1.26,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,3308,1.26,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,3308,1.26,0,0.0

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @dirkx 🚀

@aentinger aentinger merged commit f4e17ef into arduino-libraries:master Oct 27, 2022
@per1234 per1234 linked an issue Oct 28, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operator unsigned long() const; is missing
3 participants