Add interrupt feature #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 8af9c21
Click for full report table
Click for full report CSV |
per1234
requested changes
May 12, 2021
Comment on lines
+21
to
+26
| enableDataReady KEYWORD2 | ||
| disableDataReady KEYWORD2 | ||
| setOpenDrain KEYWORD2 | ||
| setPushPull KEYWORD2 | ||
| setActiveHigh KEYWORD2 | ||
| setActiveLow KEYWORD2 |
There was a problem hiding this comment.
Suggested change
| enableDataReady KEYWORD2 | |
| disableDataReady KEYWORD2 | |
| setOpenDrain KEYWORD2 | |
| setPushPull KEYWORD2 | |
| setActiveHigh KEYWORD2 | |
| setActiveLow KEYWORD2 | |
| enableDataReady KEYWORD2 | |
| disableDataReady KEYWORD2 | |
| setOpenDrain KEYWORD2 | |
| setPushPull KEYWORD2 | |
| setActiveHigh KEYWORD2 | |
| setActiveLow KEYWORD2 |
In order to be recognized by the Arduino IDE, the keyword fields must be separated by a single true tab (not spaces):
https://arduino.github.io/arduino-cli/latest/library-specification/#keywordstxt-format
| ######################################### | ||
| # Constants | ||
| ######################################### | ||
|
|
||
| FAHRENHEIT LITERAL1 | ||
| FAHRENHEIT LITERAL1 |
There was a problem hiding this comment.
Suggested change
| FAHRENHEIT LITERAL1 | |
| FAHRENHEIT LITERAL1 |
Rocketct
reviewed
Jul 26, 2021
| @@ -26,6 +26,7 @@ | |||
| #define HTS221_WHO_AM_I_REG 0x0f | |||
| #define HTS221_CTRL1_REG 0x20 | |||
| #define HTS221_CTRL2_REG 0x21 | |||
| #define HTS221_CTRL3_REG 0x22 //Dara Ready (b7 0 active high)(open drain, b6 1)(b2, 1 enable data ready) | |||
Comment on lines
+79
to
+108
| void HTS221Class::enableDataReady(){ | ||
| uint8_t data = i2cRead(HTS221_CTRL3_REG) & 0b11111000; | ||
| i2cWrite(HTS221_CTRL3_REG, data | 0b1 << 2); | ||
| } | ||
|
|
||
| void HTS221Class::disableDataReady(){ | ||
| uint8_t data = i2cRead(HTS221_CTRL3_REG) & 0b11111000; | ||
| i2cWrite(HTS221_CTRL3_REG, data | 0b0 << 2); | ||
| } | ||
|
|
||
| void HTS221Class::setOpenDrain(){ | ||
| uint8_t data = i2cRead(HTS221_CTRL3_REG) & 0b10111100; | ||
| i2cWrite(HTS221_CTRL3_REG, data | 0b1 << 6); | ||
| } | ||
|
|
||
| void HTS221Class::setPushPull(){ | ||
| uint8_t data = i2cRead(HTS221_CTRL3_REG) & 0b10111100; | ||
| i2cWrite(HTS221_CTRL3_REG, data); | ||
| } | ||
|
|
||
| void HTS221Class::setActiveHigh(){ | ||
| uint8_t data = i2cRead(HTS221_CTRL3_REG) & 0b01111111; | ||
| i2cWrite(HTS221_CTRL3_REG, data); | ||
| } | ||
|
|
||
| void HTS221Class::setActiveLow(){ | ||
| uint8_t data = i2cRead(HTS221_CTRL3_REG) & 0b01111111; | ||
| i2cWrite(HTS221_CTRL3_REG, data | 0b1 << 7); | ||
| } | ||
|
|
There was a problem hiding this comment.
do you need all these methods? where are they used? i think that is better implement only the part we need for the library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the minimun configuration to enable the interrupt pin