Fixed hang due to consecutive read tempurature #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketct
force-pushed
the
master
branch
2 times, most recently
from
eb7cc68 to
53a1ebb
Compare
sandeepmistry
approved these changes
Aug 28, 2019
src/HTS.cpp
Outdated
| @@ -72,6 +72,9 @@ void HTS221Class::end() | |||
|
|
|||
| float HTS221Class::readTemperature(int units) | |||
| { | |||
| // Wait for ONE_SHOT bit to be cleared by the hardware | |||
| while (HTS221_CTRL2_REG) & 0x01); | |||
There was a problem hiding this comment.
I think this is incorrect. shouldn't it be wrapped in i2cRead(HTS221_CTRL2_REG) ?
fix the hang issue due to consecutive reads of the temperature register porting of arduino-libraries/Arduino_MKRENV#6
sandeepmistry
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the hang issue due to consecutive reads of the temperature register
porting of arduino-libraries/Arduino_MKRENV#6
cc:\ @sandeepmistry : tested on MKRENV shield seem the in this way the issue is fixed