Skip to content

add "newlineOn" and "newlineOff" methods #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

whyameye
Copy link
Contributor

Here's a simple addition following the model of the existing code to add the ability to turn on our off newlines at the end of the debug statements. Addresses issue #17

@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Feb 18, 2022
@per1234 per1234 linked an issue Feb 18, 2022 that may be closed by this pull request
@github-actions
Copy link

Memory usage change @ 270c73e

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 +12 - +16 +0.04 - +0.06 🔺 +1 - +1 +0.04 - +0.04
arduino:avr:mega 🔺 +12 - +16 0.0 - +0.01 🔺 +1 - +1 +0.01 - +0.01
arduino:avr:nano 🔺 +12 - +16 +0.04 - +0.05 🔺 +1 - +1 +0.05 - +0.05
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 +14 - +14 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:megaavr:nona4809 🔺 +12 - +16 +0.02 - +0.03 🔺 +1 - +1 +0.02 - +0.02
arduino:sam:arduino_due_x_dbg 🔺 +8 - +8 0.0 - 0.0 N/A N/A
arduino:samd:mkrzero 🔺 +16 - +16 +0.01 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Arduino_Debug_Basic
flash
% examples/Arduino_Debug_Basic
RAM for global variables
% examples/Arduino_Debug_Advance
flash
% examples/Arduino_Debug_Advance
RAM for global variables
%
arduino:avr:leonardo 16 0.06 1 0.04 12 0.04 1 0.04
arduino:avr:mega 16 0.01 1 0.01 12 0.0 1 0.01
arduino:avr:nano 16 0.05 1 0.05 12 0.04 1 0.05
arduino:mbed_nano:nano33ble 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 14 0.0 0 0.0
arduino:mbed_portenta:envie_m4 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0
arduino:megaavr:nona4809 16 0.03 1 0.02 12 0.02 1 0.02
arduino:sam:arduino_due_x_dbg 8 0.0 N/A N/A
arduino:samd:mkrzero 16 0.01 0 0.0
Click for full report CSV
Board,examples/Arduino_Debug_Basic<br>flash,%,examples/Arduino_Debug_Basic<br>RAM for global variables,%,examples/Arduino_Debug_Advance<br>flash,%,examples/Arduino_Debug_Advance<br>RAM for global variables,%
arduino:avr:leonardo,16,0.06,1,0.04,12,0.04,1,0.04
arduino:avr:mega,16,0.01,1,0.01,12,0.0,1,0.01
arduino:avr:nano,16,0.05,1,0.05,12,0.04,1,0.05
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,,,,
arduino:mbed_nano:nanorp2040connect,14,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m4,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,,,,
arduino:megaavr:nona4809,16,0.03,1,0.02,12,0.02,1,0.02
arduino:sam:arduino_due_x_dbg,8,0.0,N/A,N/A,,,,
arduino:samd:mkrzero,16,0.01,0,0.0,,,,

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb PR 🚀 Thank you @whyameye 🙇 .

@aentinger aentinger merged commit d49fb9b into arduino-libraries:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for print and println
3 participants