Use modern API of arduino/compile-sketches action
#67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API of the `arduino/compile-sketches` GitHub Actions action used to compile the library's example sketches in the "Compile Examples" CI workflow has evolved over time. Although measures were taken to provide backwards compatibility for the old API, it turns out that the GitHub Actions behavior of creating environment variables for arbitrary input names relied upon for still recognizing the old inputs is not consistent across action types. It works fine for the Docker container action type originally used by `arduino/compile-sketches`, but not for the new "Composite Run Steps" action type we switched to. This change resulted in sketch data deltas no longer being generated due to the workflow's use of the unsupported input name `enable-size-deltas-report` (which was changed to the more appropriate `enable-deltas-report` last year). This resulted in failed runs of the "Report Size Deltas" due to the reports not having the required deltas data. The fix is simply to update to the new input name in the "Compile Examples" GitHub Actions workflow that uses the `arduino/compile-sketches` action. I also updated the contents of the action's `libraries` input to the new YAML array style. This was not mandatory because there is still backwards compatibility for the old API in this case due to the input name not having changed, but only the data format. However, the old data format is deprecated so it's safest to update. I also removed the no longer used `size-report-sketch` input. This input was removed at the time the action was changed to report on all compilations
|
Memory usage change @ cdd2dd6
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API of the
arduino/compile-sketchesGitHub Actions action used to compile the library's example sketches in the "Compile Examples" CI workflow has evolved over time. Although measures were taken to provide backwards compatibility for the old API, it turns out that the GitHub Actions behavior of creating environment variables for arbitrary input names relied upon for still recognizing the old inputs is not consistent across action types. It works fine for the Docker container action type originally used byarduino/compile-sketches, but not for the new "Composite Run Steps" action type we switched to (arduino/compile-sketches#14).This change resulted in sketch data deltas no longer being generated due to the workflow's use of the unsupported input name
enable-size-deltas-report(which was changed to the more appropriateenable-deltas-reportlast year). This resulted in failed runs of the "Report Size Deltas" due to the reports not having the required deltas data.Example:
https://github.com/arduino-libraries/Arduino_ConnectionHandler/runs/3918424017?check_suite_focus=true#step:3:17
The fix is simply to update to the new input name in the "Compile Examples" GitHub Actions workflow that uses the
arduino/compile-sketchesaction.I also updated the contents of the action's
librariesinput to the new YAML array style. This was not mandatory because there is still backwards compatibility for the old API in this case due to the input name not having changed, but only the data format. However, the old data format is deprecated so it's safest to update.I also removed the no longer used
size-report-sketchinput. This input was removed at the time the action was changed to report on all compilations