Skip to content

chore: refactor device id handling #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Mar 4, 2025

  • Migrate from sn to _arduino_device_id

LOW-RISK: The value for _device_id is only logged, but not otherwise consumed at this time.

- Migrate from `sn` to `_arduino_device_id`
Copy link

github-actions bot commented Mar 4, 2025

Memory usage change @ cb2dc7a

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 0 - +76 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 0 - +368 0.0 - +0.04 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +368 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +345 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +304 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +368 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +344 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 0 - +336 0.0 - +0.13 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +328 0.0 - +0.13 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +328 0.0 - +0.13 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 0 - +328 0.0 - +0.13 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 0 - +328 0.0 - +0.13 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 🔺 0 - +328 0.0 - +0.13 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +328 0.0 - +0.13 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +328 0.0 - +0.13 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 0 - +60 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
rp2040:rp2040:rpipicow 🔺 0 - +336 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ConnectionHandlerDemo
flash
% examples/ConnectionHandlerDemo
RAM for global variables
% examples/ConnectionHandlerDemo-Notecard
flash
% examples/ConnectionHandlerDemo-Notecard
RAM for global variables
%
arduino:esp32:nano_nora 0 0.0 0 0.0 76 0.0 0 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 0 0.0 0 0.0 368 0.04 0 0.0
arduino:mbed_giga:giga 0 0.0 0 0.0 368 0.02 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 345 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0 304 0.02 0 0.0
arduino:mbed_opta:opta 0 0.0 0 0.0 368 0.02 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 344 0.02 0 0.0
arduino:renesas_uno:unor4wifi 0 0.0 0 0.0 336 0.13 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 328 0.13 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 328 0.13 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0 328 0.13 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 328 0.13 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 328 0.13 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 328 0.13 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 328 0.13 0 0.0
esp32:esp32:esp32 0 0.0 0 0.0 60 0.0 0 0.0
esp8266:esp8266:huzzah 0 0.0 0 0.0
rp2040:rp2040:rpipicow 0 0.0 0 0.0 336 0.02 0 0.0
Click for full report CSV
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,0,0.0,0,0.0,76,0.0,0,0.0
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,0,0.0,0,0.0,368,0.04,0,0.0
arduino:mbed_giga:giga,0,0.0,0,0.0,368,0.02,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,345,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,304,0.02,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,368,0.02,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,344,0.02,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0,336,0.13,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,328,0.13,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,328,0.13,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,328,0.13,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,328,0.13,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,328,0.13,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,328,0.13,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,328,0.13,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,60,0.0,0,0.0
esp8266:esp8266:huzzah,0,0.0,0,0.0,,,,
rp2040:rp2040:rpipicow,0,0.0,0,0.0,336,0.02,0,0.0

@pennam pennam merged commit b1804f3 into arduino-libraries:master Mar 10, 2025
23 checks passed
@zfields zfields deleted the notehub branch March 12, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants