Skip to content

Add tinycbor #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Add tinycbor #5

merged 3 commits into from
Dec 3, 2024

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Nov 20, 2024

No description provided.

Copy link

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the files in src/tinycbor are maintained externally, it will be best to resolve the spell check failure by configuring the codespell spell checker tool to skip the files under that folder. This should be done by adding a configuration file to the root of the repository, then adding that path to the skip property in the file. The standardized base configuration file intended for use in all Arduino repositories is hosted here:

https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/spell-check/.codespellrc


If these files are maintained externally, it would be very helpful to add a src/tinycbor/README.md file that documents that fact, and provides a link to the upstream source. That information will provide several benefits to the project maintainers. For example, allowing them to:

  • understand the correct approach to maintaining the content in cases like the spell check failures
  • redirect proposals for enhancements to the code to the appropriate channel
  • pull in fixes and enhancements from upstream

@pennam
Copy link
Collaborator Author

pennam commented Nov 21, 2024

Thanks @per1234 I will do it ! 💪

@pennam pennam force-pushed the cbor branch 2 times, most recently from 33557c3 to d42ee3f Compare December 3, 2024 10:39
Copy link

github-actions bot commented Dec 3, 2024

Memory usage change @ 6546d68

Board flash % RAM for global variables %
arduino:esp32:nano_nora 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_edge:edge_control 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi ❔ -12 - +4 -0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 +96 - +96 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 +96 - +96 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 +96 - +96 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
esp32:esp32:esp32 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/lzssDecoder
flash
% examples/lzssDecoder
RAM for global variables
% examples/crc32
flash
% examples/crc32
RAM for global variables
% examples/crc16
flash
% examples/crc16
RAM for global variables
% examples/sha256
flash
% examples/sha256
RAM for global variables
% examples/boardID
flash
% examples/boardID
RAM for global variables
%
arduino:esp32:nano_nora 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_edge:edge_control 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_giga:giga 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 4 0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0 -12 -0.0 0 0.0 4 0.0 0 0.0
arduino:samd:mkr1000 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0
arduino:samd:mkrgsm1400 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0
arduino:samd:mkrnb1500 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0 96 0.04 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/lzssDecoder<br>flash,%,examples/lzssDecoder<br>RAM for global variables,%,examples/crc32<br>flash,%,examples/crc32<br>RAM for global variables,%,examples/crc16<br>flash,%,examples/crc16<br>RAM for global variables,%,examples/sha256<br>flash,%,examples/sha256<br>RAM for global variables,%,examples/boardID<br>flash,%,examples/boardID<br>RAM for global variables,%
arduino:esp32:nano_nora,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_edge:edge_control,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_giga:giga,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:renesas_uno:unor4wifi,4,0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0,-12,-0.0,0,0.0,4,0.0,0,0.0
arduino:samd:mkr1000,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0
arduino:samd:mkrgsm1400,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0
arduino:samd:mkrnb1500,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0,96,0.04,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@pennam pennam merged commit b9b8137 into arduino-libraries:main Dec 3, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants