Skip to content

renaming sha256 functions to avoid clashing with esp8266:esp8266:huzzah #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

renaming sha256 functions to avoid clashing with esp8266:esp8266:huzzah #19

merged 1 commit into from
Feb 25, 2025

Conversation

andreagilardoni
Copy link
Collaborator

No description provided.

pennam
pennam requested changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to rename also sha256_ctx to keep naming consistent, maybe also SHA256_DIGEST_SIZE SHA256_BLOCK_SIZE or wrap them to avoid redefinition warnings

#ifndef SHA256_DIGEST_SIZE
  #define SHA256_DIGEST_SIZE ( 256 / 8)
#endif

@andreagilardoni andreagilardoni force-pushed the sha256-rename branch 2 times, most recently from a117e7f to 0ecfa21 Compare February 25, 2025 11:45
@pennam pennam mentioned this pull request Feb 25, 2025
Merged
@andreagilardoni andreagilardoni merged commit f8689d7 into arduino-libraries:main Feb 25, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam pennam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreagilardoni @pennam