Skip to content

Fix sendSMS function #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix sendSMS function #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ArduinoCellular.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ Time ArduinoCellular::getCellularTime(){


void ArduinoCellular::sendSMS(String number, String message){
modem.sendAT("+CMGF=1");
modem.waitResponse(1000);
Comment on lines +130 to +131
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module is already set to text mode in the .begin() function.

Arduino_Cellular/src/ArduinoCellular.cpp

Lines 30 to 32 in 414d5e3

// Set GSM module to text mode
modem.sendAT("+CMGF=1");
modem.waitResponse();

@cristidragomir97 would setting the text format again here increase the stability of the library?

modem.sendAT(GF("+CMGS=\""), number, GF("\""));
if (modem.waitResponse(GF(">")) != 1) { }
modem.stream->print(message); // Actually send the message
Expand Down
Loading