Skip to content

Fix: SmartServoClass::getPosition return value #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

metanav
Copy link
Contributor

@metanav metanav commented Feb 22, 2023

This PR fixes the issue #97.

@github-actions
Copy link

Memory usage change @ 1bc38c5

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 🔺 0 - +28 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Braccio_Record_and_Replay
flash
% examples/Braccio_Record_and_Replay
RAM for global variables
% examples/Controlling_Manually_Braccio
flash
% examples/Controlling_Manually_Braccio
RAM for global variables
% examples/Platform_Tutorials/lessons/03-important-programming-concepts/Braccio_moving_range_angles
flash
% examples/Platform_Tutorials/lessons/03-important-programming-concepts/Braccio_moving_range_angles
RAM for global variables
% examples/Platform_Tutorials/lessons/03-important-programming-concepts/Navigating_the_display_menu
flash
% examples/Platform_Tutorials/lessons/03-important-programming-concepts/Navigating_the_display_menu
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/01_creating_a_button
flash
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/01_creating_a_button
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/02_designing_the_button
flash
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/02_designing_the_button
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/03_creating_a_menu
flash
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/03_creating_a_menu
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/04_testing_it_out
flash
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/04_testing_it_out
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/05_display_challenge
flash
% examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/05_display_challenge
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/01_playing_with_the_Joystick
flash
% examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/01_playing_with_the_Joystick
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/02_handling_events_in_the_menu
flash
% examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/02_handling_events_in_the_menu
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/03_navigate_challenge_I
flash
% examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/03_navigate_challenge_I
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/04_navigate_challenge_II
flash
% examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/04_navigate_challenge_II
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/01_playing_with_the_motors
flash
% examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/01_playing_with_the_motors
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/02_selecting_the_motor_with_the_enter_button
flash
% examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/02_selecting_the_motor_with_the_enter_button
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/03_moving_the_motors_with_the_joystick
flash
% examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/03_moving_the_motors_with_the_joystick
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/04_servo_motors_challenge
flash
% examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/04_servo_motors_challenge
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/01_playing_with_a_joint_angle_gauge
flash
% examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/01_playing_with_a_joint_angle_gauge
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/02_selecting_the_motor_in_the_LCD_menu
flash
% examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/02_selecting_the_motor_in_the_LCD_menu
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/03_learnings_challenge_I
flash
% examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/03_learnings_challenge_I
RAM for global variables
% examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/04_learnings_challenge_II
flash
% examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/04_learnings_challenge_II
RAM for global variables
% examples/Platform_Tutorials/projects/p01-moving-braccio/01_aligning_braccio
flash
% examples/Platform_Tutorials/projects/p01-moving-braccio/01_aligning_braccio
RAM for global variables
% examples/Platform_Tutorials/projects/p01-moving-braccio/02_waving_with_Braccio
flash
% examples/Platform_Tutorials/projects/p01-moving-braccio/02_waving_with_Braccio
RAM for global variables
% examples/Platform_Tutorials/projects/p01-moving-braccio/03_moving_challenge
flash
% examples/Platform_Tutorials/projects/p01-moving-braccio/03_moving_challenge
RAM for global variables
% examples/Platform_Tutorials/projects/p02-controlling-braccio-manually/01_Controlling_Manually_Braccio
flash
% examples/Platform_Tutorials/projects/p02-controlling-braccio-manually/01_Controlling_Manually_Braccio
RAM for global variables
% examples/Platform_Tutorials/projects/p02-controlling-braccio-manually/02_Manual_Control_Challenge
flash
% examples/Platform_Tutorials/projects/p02-controlling-braccio-manually/02_Manual_Control_Challenge
RAM for global variables
% examples/Platform_Tutorials/projects/p03-record-replay-mode/01_Braccio_Record_and_Replay
flash
% examples/Platform_Tutorials/projects/p03-record-replay-mode/01_Braccio_Record_and_Replay
RAM for global variables
% examples/Platform_Tutorials/projects/p03-record-replay-mode/02_Record_Replay_challenge
flash
% examples/Platform_Tutorials/projects/p03-record-replay-mode/02_Record_Replay_challenge
RAM for global variables
% examples/Tools/Braccio_Basic
flash
% examples/Tools/Braccio_Basic
RAM for global variables
% examples/Tools/Factory_Set_ID_Interactive
flash
% examples/Tools/Factory_Set_ID_Interactive
RAM for global variables
% examples/Tools/Factory_Set_Initial_Servo_Position
flash
% examples/Tools/Factory_Set_Initial_Servo_Position
RAM for global variables
% examples/Tools/LCD_Custom_Menu
flash
% examples/Tools/LCD_Custom_Menu
RAM for global variables
% examples/Tools/LCD_Menu_Joystick
flash
% examples/Tools/LCD_Menu_Joystick
RAM for global variables
% examples/Tools/LCD_Motors
flash
% examples/Tools/LCD_Motors
RAM for global variables
% examples/Tools/Test_Inputs
flash
% examples/Tools/Test_Inputs
RAM for global variables
% examples/Tools/Test_Motor_Angular_Control
flash
% examples/Tools/Test_Motor_Angular_Control
RAM for global variables
% examples/Tools/Test_Motor_Communication
flash
% examples/Tools/Test_Motor_Communication
RAM for global variables
%
arduino:mbed_nano:nanorp2040connect 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 28 0.0 0 0.0 0 0.0 0 0.0 28 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 28 0.0 0 0.0 0 0.0 0 0.0 28 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/Braccio_Record_and_Replay<br>flash,%,examples/Braccio_Record_and_Replay<br>RAM for global variables,%,examples/Controlling_Manually_Braccio<br>flash,%,examples/Controlling_Manually_Braccio<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/03-important-programming-concepts/Braccio_moving_range_angles<br>flash,%,examples/Platform_Tutorials/lessons/03-important-programming-concepts/Braccio_moving_range_angles<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/03-important-programming-concepts/Navigating_the_display_menu<br>flash,%,examples/Platform_Tutorials/lessons/03-important-programming-concepts/Navigating_the_display_menu<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/01_creating_a_button<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/01_creating_a_button<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/02_designing_the_button<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/02_designing_the_button<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/03_creating_a_menu<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/03_creating_a_menu<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/04_testing_it_out<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/04_testing_it_out<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/05_display_challenge<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/01-programming-the-braccio-display/05_display_challenge<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/01_playing_with_the_Joystick<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/01_playing_with_the_Joystick<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/02_handling_events_in_the_menu<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/02_handling_events_in_the_menu<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/03_navigate_challenge_I<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/03_navigate_challenge_I<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/04_navigate_challenge_II<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/02-navigatting-the-display-menu/04_navigate_challenge_II<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/01_playing_with_the_motors<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/01_playing_with_the_motors<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/02_selecting_the_motor_with_the_enter_button<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/02_selecting_the_motor_with_the_enter_button<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/03_moving_the_motors_with_the_joystick<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/03_moving_the_motors_with_the_joystick<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/04_servo_motors_challenge<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/03-playing-with-the-motors/04_servo_motors_challenge<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/01_playing_with_a_joint_angle_gauge<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/01_playing_with_a_joint_angle_gauge<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/02_selecting_the_motor_in_the_LCD_menu<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/02_selecting_the_motor_in_the_LCD_menu<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/03_learnings_challenge_I<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/03_learnings_challenge_I<br>RAM for global variables,%,examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/04_learnings_challenge_II<br>flash,%,examples/Platform_Tutorials/lessons/Basic_codes/04-integration-of-previous-learnings/04_learnings_challenge_II<br>RAM for global variables,%,examples/Platform_Tutorials/projects/p01-moving-braccio/01_aligning_braccio<br>flash,%,examples/Platform_Tutorials/projects/p01-moving-braccio/01_aligning_braccio<br>RAM for global variables,%,examples/Platform_Tutorials/projects/p01-moving-braccio/02_waving_with_Braccio<br>flash,%,examples/Platform_Tutorials/projects/p01-moving-braccio/02_waving_with_Braccio<br>RAM for global variables,%,examples/Platform_Tutorials/projects/p01-moving-braccio/03_moving_challenge<br>flash,%,examples/Platform_Tutorials/projects/p01-moving-braccio/03_moving_challenge<br>RAM for global variables,%,examples/Platform_Tutorials/projects/p02-controlling-braccio-manually/01_Controlling_Manually_Braccio<br>flash,%,examples/Platform_Tutorials/projects/p02-controlling-braccio-manually/01_Controlling_Manually_Braccio<br>RAM for global variables,%,examples/Platform_Tutorials/projects/p02-controlling-braccio-manually/02_Manual_Control_Challenge<br>flash,%,examples/Platform_Tutorials/projects/p02-controlling-braccio-manually/02_Manual_Control_Challenge<br>RAM for global variables,%,examples/Platform_Tutorials/projects/p03-record-replay-mode/01_Braccio_Record_and_Replay<br>flash,%,examples/Platform_Tutorials/projects/p03-record-replay-mode/01_Braccio_Record_and_Replay<br>RAM for global variables,%,examples/Platform_Tutorials/projects/p03-record-replay-mode/02_Record_Replay_challenge<br>flash,%,examples/Platform_Tutorials/projects/p03-record-replay-mode/02_Record_Replay_challenge<br>RAM for global variables,%,examples/Tools/Braccio_Basic<br>flash,%,examples/Tools/Braccio_Basic<br>RAM for global variables,%,examples/Tools/Factory_Set_ID_Interactive<br>flash,%,examples/Tools/Factory_Set_ID_Interactive<br>RAM for global variables,%,examples/Tools/Factory_Set_Initial_Servo_Position<br>flash,%,examples/Tools/Factory_Set_Initial_Servo_Position<br>RAM for global variables,%,examples/Tools/LCD_Custom_Menu<br>flash,%,examples/Tools/LCD_Custom_Menu<br>RAM for global variables,%,examples/Tools/LCD_Menu_Joystick<br>flash,%,examples/Tools/LCD_Menu_Joystick<br>RAM for global variables,%,examples/Tools/LCD_Motors<br>flash,%,examples/Tools/LCD_Motors<br>RAM for global variables,%,examples/Tools/Test_Inputs<br>flash,%,examples/Tools/Test_Inputs<br>RAM for global variables,%,examples/Tools/Test_Motor_Angular_Control<br>flash,%,examples/Tools/Test_Motor_Angular_Control<br>RAM for global variables,%,examples/Tools/Test_Motor_Communication<br>flash,%,examples/Tools/Test_Motor_Communication<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,28,0.0,0,0.0,0,0.0,0,0.0,28,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,28,0.0,0,0.0,0,0.0,0,0.0,28,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Feb 22, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , only a minor improvement idea.

metanav and others added 2 commits February 22, 2023 14:51
Co-authored-by: Alexander Entinger <[email protected]>
…s build error a couple of lines down - my bad.

This reverts commit 1217b07.
Copy link
Contributor Author

@metanav metanav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good now.

@aentinger aentinger merged commit 3c9371e into arduino-libraries:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants