Rename Learn/Repeat example to be consistent with menu naming (Record/Replay instead of Learn/Repeat) #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aentinger
added
type: enhancement
|
Let's have CI one complete run to make sure I did not mess up anything while renaming/copying. |
|
Memory usage change @ 3706bbd
Click for full report table
Click for full report CSV |
Esquirio
reviewed
May 11, 2022
There was a problem hiding this comment.
Hello @aentinger.
I've tested the changes, and the code continues to freeze sometimes in replay mode. Another finding is when I tried to record a second movement after Braccio performed the first one, the code also froze (See video that I recorded).
I suggest separating the code parts (recording the positions and display layout) and testing the position record using the Enter button to change the states (RECORD, REPLAY). So we can check if the issue happens without the LVGL library.
You can use a library like MemoryUsage to verify if the problem is full memory.
Another thing, It is necessary to change the name of the project 03; instead 01_Braccio_Learn_and_Repeat, we have to use 01_Braccio_Record_and_Replay
cc: @clodpheasant
Can you please provide a textual description of what you did until you experienced an issue? From the video its hard to judge what inputs you fed into the software until error. What does
mean exactly? I interpret it to mean that you've recorded i.e. 170 positions and in replay there are only 40 replayed. Can you confirm my interpretation or elaborate? Probably best to open a separate issue since this PR is mainly intended as a rename. |
|
Memory usage change @ b2b03bb
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.