-
Notifications
You must be signed in to change notification settings - Fork 15
Fixing the comparison for setting the input current limit to 900 mA. #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Rob Singleton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Memory usage change @ cc834bf
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rsingletonDS. Thanks so much for your pull request!
I see that the @CLAassistant bot has not been able to validate the pull request.
As explained by the bot, this is likely caused by the email address used in your local Git settings not being associated with your GitHub account.
You can see the email address associated with the commit here:
Please follow these instructions to resolve the issue:
Hopefully the check will automatically pass once that has been done. If not, please comment here and we will investigate.
As soon as the CLA is singed I'll go on and merge this (or probably @per1234 you can do it too 🙂 ) |
This fixes the 900 mA input current limit setting. It doesn't have the double/float comparison fix you asked me to remove.