Skip to content

AdvancedADC: Increase the maximum number of channels. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2024
Merged

AdvancedADC: Increase the maximum number of channels. #61

merged 2 commits into from
Mar 20, 2024

Conversation

iabdalkader
Copy link
Collaborator

Fixes #39

@iabdalkader iabdalkader requested a review from facchinm March 18, 2024 12:25
@github-actions GitHub Actions
Copy link

Memory usage change @ aa3e6bc

Board flash % RAM for global variables %
arduino:mbed_giga:giga 🔺 0 - +48 0.0 - 0.0 🔺 0 - +40 0.0 - +0.01
Click for full report table
Board examples/Advanced/ADC_Multi
flash		 % examples/Advanced/ADC_Multi
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel
flash		 % examples/Advanced/ADC_Multi_Channel
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel_Dynamic
flash		 % examples/Advanced/ADC_Multi_Channel_Dynamic
RAM for global variables		 % examples/Advanced/ADC_Multi_To_DAC
flash		 % examples/Advanced/ADC_Multi_To_DAC
RAM for global variables		 % examples/Advanced/ADC_Serial_Plotter
flash		 % examples/Advanced/ADC_Serial_Plotter
RAM for global variables		 % examples/Advanced/ADC_To_DAC
flash		 % examples/Advanced/ADC_To_DAC
RAM for global variables		 % examples/Advanced/DAC_One_Channel
flash		 % examples/Advanced/DAC_One_Channel
RAM for global variables		 % examples/Advanced/DAC_Sine_wave
flash		 % examples/Advanced/DAC_Sine_wave
RAM for global variables		 % examples/Advanced/DAC_Two_Channels
flash		 % examples/Advanced/DAC_Two_Channels
RAM for global variables		 % examples/Advanced/I2S_DAC_Output
flash		 % examples/Advanced/I2S_DAC_Output
RAM for global variables		 % examples/Advanced/I2S_Full_Duplex
flash		 % examples/Advanced/I2S_Full_Duplex
RAM for global variables		 % examples/Beginner/Audio_Playback
flash		 % examples/Beginner/Audio_Playback
RAM for global variables		 % examples/Beginner/Audio_Playback_I2S
flash		 % examples/Beginner/Audio_Playback_I2S
RAM for global variables		 % examples/Beginner/Waveform_Generator
flash		 % examples/Beginner/Waveform_Generator
RAM for global variables		 %
arduino:mbed_giga:giga 48 0.0 40 0.01 48 0.0 24 0.0 40 0.0 24 0.0 48 0.0 40 0.01 48 0.0 24 0.0 48 0.0 24 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Advanced/ADC_Multi<br>flash,%,examples/Advanced/ADC_Multi<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel<br>flash,%,examples/Advanced/ADC_Multi_Channel<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel_Dynamic<br>flash,%,examples/Advanced/ADC_Multi_Channel_Dynamic<br>RAM for global variables,%,examples/Advanced/ADC_Multi_To_DAC<br>flash,%,examples/Advanced/ADC_Multi_To_DAC<br>RAM for global variables,%,examples/Advanced/ADC_Serial_Plotter<br>flash,%,examples/Advanced/ADC_Serial_Plotter<br>RAM for global variables,%,examples/Advanced/ADC_To_DAC<br>flash,%,examples/Advanced/ADC_To_DAC<br>RAM for global variables,%,examples/Advanced/DAC_One_Channel<br>flash,%,examples/Advanced/DAC_One_Channel<br>RAM for global variables,%,examples/Advanced/DAC_Sine_wave<br>flash,%,examples/Advanced/DAC_Sine_wave<br>RAM for global variables,%,examples/Advanced/DAC_Two_Channels<br>flash,%,examples/Advanced/DAC_Two_Channels<br>RAM for global variables,%,examples/Advanced/I2S_DAC_Output<br>flash,%,examples/Advanced/I2S_DAC_Output<br>RAM for global variables,%,examples/Advanced/I2S_Full_Duplex<br>flash,%,examples/Advanced/I2S_Full_Duplex<br>RAM for global variables,%,examples/Beginner/Audio_Playback<br>flash,%,examples/Beginner/Audio_Playback<br>RAM for global variables,%,examples/Beginner/Audio_Playback_I2S<br>flash,%,examples/Beginner/Audio_Playback_I2S<br>RAM for global variables,%,examples/Beginner/Waveform_Generator<br>flash,%,examples/Beginner/Waveform_Generator<br>RAM for global variables,%
arduino:mbed_giga:giga,48,0.0,40,0.01,48,0.0,24,0.0,40,0.0,24,0.0,48,0.0,40,0.01,48,0.0,24,0.0,48,0.0,24,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 18, 2024
leonardocavagnis
leonardocavagnis requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything sounds good!
Please update also the docs/readme.md file

Arduino_AdvancedAnalog/docs/readme.md

Line 59 in 372b127

Each ADC instance can handle up to **five** channels.

@iabdalkader
docs: Update README.
e600d70 
Signed-off-by: iabdalkader <[email protected]>
@iabdalkader
Copy link
Collaborator Author

Everything sounds good! Please update also the docs/readme.md file

Arduino_AdvancedAnalog/docs/readme.md

Line 59 in 372b127

Each ADC instance can handle up to **five** channels.

Good catch! Updated. Note that all docs will be updated before the next release, to add the new features.

@github-actions GitHub Actions
Copy link

Memory usage change @ e600d70

Board flash % RAM for global variables %
arduino:mbed_giga:giga 🔺 0 - +48 0.0 - 0.0 🔺 0 - +40 0.0 - +0.01
Click for full report table
Board examples/Advanced/ADC_Multi
flash		 % examples/Advanced/ADC_Multi
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel
flash		 % examples/Advanced/ADC_Multi_Channel
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel_Dynamic
flash		 % examples/Advanced/ADC_Multi_Channel_Dynamic
RAM for global variables		 % examples/Advanced/ADC_Multi_To_DAC
flash		 % examples/Advanced/ADC_Multi_To_DAC
RAM for global variables		 % examples/Advanced/ADC_Serial_Plotter
flash		 % examples/Advanced/ADC_Serial_Plotter
RAM for global variables		 % examples/Advanced/ADC_To_DAC
flash		 % examples/Advanced/ADC_To_DAC
RAM for global variables		 % examples/Advanced/DAC_One_Channel
flash		 % examples/Advanced/DAC_One_Channel
RAM for global variables		 % examples/Advanced/DAC_Sine_wave
flash		 % examples/Advanced/DAC_Sine_wave
RAM for global variables		 % examples/Advanced/DAC_Two_Channels
flash		 % examples/Advanced/DAC_Two_Channels
RAM for global variables		 % examples/Advanced/I2S_DAC_Output
flash		 % examples/Advanced/I2S_DAC_Output
RAM for global variables		 % examples/Advanced/I2S_Full_Duplex
flash		 % examples/Advanced/I2S_Full_Duplex
RAM for global variables		 % examples/Beginner/Audio_Playback
flash		 % examples/Beginner/Audio_Playback
RAM for global variables		 % examples/Beginner/Audio_Playback_I2S
flash		 % examples/Beginner/Audio_Playback_I2S
RAM for global variables		 % examples/Beginner/Waveform_Generator
flash		 % examples/Beginner/Waveform_Generator
RAM for global variables		 %
arduino:mbed_giga:giga 48 0.0 40 0.01 48 0.0 24 0.0 40 0.0 24 0.0 48 0.0 40 0.01 48 0.0 24 0.0 48 0.0 24 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Advanced/ADC_Multi<br>flash,%,examples/Advanced/ADC_Multi<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel<br>flash,%,examples/Advanced/ADC_Multi_Channel<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel_Dynamic<br>flash,%,examples/Advanced/ADC_Multi_Channel_Dynamic<br>RAM for global variables,%,examples/Advanced/ADC_Multi_To_DAC<br>flash,%,examples/Advanced/ADC_Multi_To_DAC<br>RAM for global variables,%,examples/Advanced/ADC_Serial_Plotter<br>flash,%,examples/Advanced/ADC_Serial_Plotter<br>RAM for global variables,%,examples/Advanced/ADC_To_DAC<br>flash,%,examples/Advanced/ADC_To_DAC<br>RAM for global variables,%,examples/Advanced/DAC_One_Channel<br>flash,%,examples/Advanced/DAC_One_Channel<br>RAM for global variables,%,examples/Advanced/DAC_Sine_wave<br>flash,%,examples/Advanced/DAC_Sine_wave<br>RAM for global variables,%,examples/Advanced/DAC_Two_Channels<br>flash,%,examples/Advanced/DAC_Two_Channels<br>RAM for global variables,%,examples/Advanced/I2S_DAC_Output<br>flash,%,examples/Advanced/I2S_DAC_Output<br>RAM for global variables,%,examples/Advanced/I2S_Full_Duplex<br>flash,%,examples/Advanced/I2S_Full_Duplex<br>RAM for global variables,%,examples/Beginner/Audio_Playback<br>flash,%,examples/Beginner/Audio_Playback<br>RAM for global variables,%,examples/Beginner/Audio_Playback_I2S<br>flash,%,examples/Beginner/Audio_Playback_I2S<br>RAM for global variables,%,examples/Beginner/Waveform_Generator<br>flash,%,examples/Beginner/Waveform_Generator<br>RAM for global variables,%
arduino:mbed_giga:giga,48,0.0,40,0.01,48,0.0,24,0.0,40,0.0,24,0.0,48,0.0,40,0.01,48,0.0,24,0.0,48,0.0,24,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@iabdalkader iabdalkader merged commit 2309705 into main Mar 20, 2024
6 checks passed
@iabdalkader iabdalkader deleted the adc_n_channels branch March 20, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardocavagnis leonardocavagnis leonardocavagnis approved these changes

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of ADC channels arbitrarily limited
3 participants
@iabdalkader @leonardocavagnis @per1234