Allow setting list of pins to sample after construction #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arguably, in user code, the list of pins to sample will typically be known and fixed at compile-time. However, when wrapping this into a library (Mozzi; for the purpose of providing a cross-platform analog read mechanism), it will be very helpful to have a way to adjust the pins to sample after construction.
|
Memory usage change @ 04f1275
Click for full report table
Click for full report CSV |
I shall test my PR before submitting...
|
Memory usage change @ 82ae24a
Click for full report table
Click for full report CSV |
|
Hi @tfry-git ☕ 👋 Can you please provide an example show-casing how you'd use this feature? |
For clarification: Do you want an example of how I would actually use this (in order to judge, whether the proposed change makes sense), or do you want me to provide a user visible example for inclusion in examples-dir? I'll happily provide the second, if that's what you mean. As for the first: My actual use-case is a library for audio synthesis (Mozzi). Note that Mozzi is cross platform, and the user-facing API already exists, so from the Mozzi point of view this PR is about enabling an implementation on the Giga. More specifically, we have a function Regarding the API, none of the other existing platform ports require prior specification of the pins that will be used in mozziAnalogRead() -> update list of pins to sample -> trigger hardware-specific non-blocking readings of these pins -> cache the resulting values -> to be returned in a subsequent call of mozziAnalogRead() Regarding possible way to accomplish this, I see the following options:
|
|
Hi @tfry-git ☕ 👋 Judging by the current state of your PR I consider it non-invasive, hence would be happy to merge.
Yes, this would be about the second option. If you could add such an example to this PR I'll be happy to merge 🙇 . |
|
|
|
Example added. |
|
Memory usage change @ 4c36569
Click for full report table
Click for full report CSV |
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably, in user code, the list of pins to sample will typically be known and fixed at compile-time.
However, when wrapping this into a library (Mozzi; for the purpose of providing a cross-platform analog read mechanism), it will be very helpful to have a way to adjust the pins to sample after construction.