Fixes and updates. #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iabdalkader
commented
Apr 4, 2023
iabdalkader
commented
- Fix DMA buffer Queue memory issues.
- Misc improvements to make DAC more robust.
- Update Waveform_Generator.ino example.
- Fixes Programming >2M Samples/sec on DAC seems to cause Giga board to hang #32
- Fixes DMA DAC intialization is unstable #35
* The current underlying DMA buffer Queue is not thread-safe and in some cases it can corrupt the memory. Replace the underlying DMA buffer container with a thread-safe implementation.
* Detect DAC underrun in available() and reset if needed. If DAC stops for any reason, no buffers will become free again. We need to detect this and abort. * Flush all pending buffers when DAC is stopped. This releases back all the buffers to the ready queue, and fixes an edge case where DAC stops while holding all of the ready buffers. * Check for NULL descriptor pointers in every function. * Increase DMA stream priority to highest.
* Add new command to stop DAC ("k").
* Print memory usage.
* Increase max frequency to 128KHz.
* Use a smaller DMA buffer size and rework the wave generators
to support it.
|
Memory usage change @ e21c57b
Click for full report table
Click for full report CSV |
|
Hi @aentinger can you please review this and if it looks good, merge and do another release ? Thanks. |
aentinger
reviewed
Apr 11, 2023
Yes it should be very safe, the old one shared the variables between push/pop producer/consumer sides, this one even if the tail/head is moved during push/pop it should still be safe and there's no shared |
|
Check, thanks for the clarification 👍 |
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.