-
Notifications
You must be signed in to change notification settings - Fork 77
Added Compatibility to ESP32 and ESP8266 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rseidt
wants to merge
1
commit into
arduino-libraries:master
Choose a base branch
from
rseidt:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Robert Seidt <[email protected]>
Memory usage change @ 9692cbc
Click for full report table
Click for full report CSV
|
jacobq
reviewed
Feb 9, 2025
@@ -43,6 +43,10 @@ | |||
#define SERIAL_PORT_HARDWARE Serial1 | |||
#define RS485_DEFAULT_DE_PIN 8 | |||
#define RS485_DEFAULT_RE_PIN 7 | |||
#elif defined(ESP32) || defined(ESP8266) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is this needed to fix the uint16_t
issue (#16)? I assume it is intended to prevent RS485_DEFAULT_DE_PIN
and RS485_DEFAULT_RE_PIN
from being defined as Arduino pin names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the ESP platform the SerialConfig enum is defined as an int32 instead of int16 as for the other platforms. So based on the idea of PR #16 from @mostafahk which seems kind of abondoned (last commit 2 years ago) I made the type dynamic.
Based on this change this will enable the ModBus Library to work on the espressifs