Skip to content

More general solution for external RS485_DEFAULT_DE_PIN and RS485_DEFAULT_RE_PIN definition #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/compile-examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,36 +34,47 @@ jobs:
- fqbn: arduino:samd:mkrzero
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkrzero
- fqbn: arduino:samd:mkr1000
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkr1000
- fqbn: arduino:samd:mkrwifi1010
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkrwifi1010
- fqbn: arduino:samd:mkrfox1200
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkrfox1200
- fqbn: arduino:samd:mkrwan1300
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkrwan1300
- fqbn: arduino:samd:mkrwan1310
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkrwan1310
- fqbn: arduino:samd:mkrgsm1400
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkrgsm1400
- fqbn: arduino:samd:mkrnb1500
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkrnb1500
- fqbn: arduino:samd:mkrvidor4000
platforms: |
- name: arduino:samd
artifact-name-suffix: arduino-samd-mkrvidor4000
- fqbn: arduino:mbed_portenta:envie_m7
platforms: |
- name: arduino:mbed_portenta
artifact-name-suffix: arduino-mbed_portenta-envie_m7
- fqbn: arduino:mbed_opta:opta
platforms: |
- name: arduino:mbed_opta
artifact-name-suffix: arduino-suffix-opta

steps:
- name: Checkout repository
Expand All @@ -86,8 +97,8 @@ jobs:
sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }}

- name: Save sketches report as workflow artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
if-no-files-found: error
path: ${{ env.SKETCHES_REPORTS_PATH }}
name: ${{ env.SKETCHES_REPORTS_PATH }}
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
4 changes: 2 additions & 2 deletions .github/workflows/report-size-deltas.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ jobs:
- name: Comment size deltas reports to PRs
uses: arduino/report-size-deltas@v1
with:
# The name of the workflow artifact created by the sketch compilation workflow
sketches-reports-source: sketches-reports
# Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow
sketches-reports-source: ^sketches-report-.+
6 changes: 3 additions & 3 deletions .github/workflows/sync-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }}

- name: Pass configuration files to next job via workflow artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
path: |
*.yaml
Expand Down Expand Up @@ -108,13 +108,13 @@ jobs:
uses: actions/checkout@v4

- name: Download configuration files artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ env.CONFIGURATIONS_ARTIFACT }}
path: ${{ env.CONFIGURATIONS_FOLDER }}

- name: Remove unneeded artifact
uses: geekyeggo/delete-artifact@v2
uses: geekyeggo/delete-artifact@v4
with:
name: ${{ env.CONFIGURATIONS_ARTIFACT }}

Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.idea/
7 changes: 7 additions & 0 deletions src/RS485.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@
#endif
#endif

#ifdef CUSTOM_RS485_DEFAULT_DE_PIN
# define RS485_DEFAULT_DE_PIN CUSTOM_RS485_DEFAULT_DE_PIN
#endif

#ifdef CUSTOM_RS485_DEFAULT_RE_PIN
# define RS485_DEFAULT_RE_PIN CUSTOM_RS485_DEFAULT_RE_PIN
#endif

#define RS485_DEFAULT_PRE_DELAY 50
#define RS485_DEFAULT_POST_DELAY 50
Expand Down