Skip to content

Encapsulate provision of time within one single object #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2020

Conversation

aentinger
Copy link
Contributor

@aentinger aentinger commented Feb 24, 2020

Successfully tested on PROD with

  • MKR 1000 ✔️
  • MKR WiFi 1010 ✔️
  • MKR GSM 1400 ✔️
  • ESP8266 ✔️

@aentinger aentinger force-pushed the cleanup-time-provision branch from aa3d511 to ffd1152 Compare February 24, 2020 11:52
@TravisBuddy

This comment has been minimized.

…ficate verification within the class TimeService
@TravisBuddy

This comment has been minimized.

…here is no need for time services for certificate verification
@aentinger aentinger force-pushed the cleanup-time-provision branch from ffd1152 to 3bab053 Compare February 24, 2020 12:02
@aentinger aentinger requested a review from AlbyIanna February 25, 2020 06:48
@aentinger aentinger marked this pull request as ready for review February 25, 2020 07:20
@aentinger aentinger merged commit c2cca46 into master Feb 25, 2020
@aentinger aentinger deleted the cleanup-time-provision branch February 25, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants